Saeid Ghafouri
Saeid Ghafouri
Yes, your suggestion worked perfectly! Please check the new commit.
Sure, I'll be happy to add the tests. I'll add the updates when I get a chance.
> @saeid93 Do you still plan on working on this? Yes, sorry I had some busy weeks, I'll work on it on this weekend if there isn't a strict deadline.
@BenjaminBossan I added the tests and also changed the code according to your comments, please let me know if further changes are required. About the docs, I wasn't sure if...
@BenjaminBossan sorry for the delay, I was on annual leave. I made the changes you asked for, please let me know if you need any more changes.
@BenjaminBossan sure, glad to be of any help. I think all the comments have now been applied. I ran the style every time, probably it was the version mismatch, hopefully,...
@BenjaminBossan no problem! I did run the style, I'm not sure why it wasn't caught locally. I just removed the line. Hopefully, it will go through this time.
Done 👍 I had to make a small change and use `tuple` instead of `Tuple` to avoid ruff complaints after adding `from __future__ import annotations`.
No problem! About your question, as far as I understand removing the check won't solve the problem since there will be a mismatch between input size and the number of...
Hi @BenjaminBossan , My recent pull request will not solve this issue. That pull requests solved https://github.com/huggingface/peft/issues/1960 . This one is a MobileViT specific problem which I was thinking to...