Naming convention/Auto Dismissal

[pgudivadaDiligent]

I really liked this library and thanks for this repo.

• Is there a specific reason why the pod is called SwiftyOverlay, and view is called GDOverlay while the delegate is called SkipOverlayDelegate (probably instead of the delegate may be a completion handler will simplify the process further)

• Also there is no auto dismissal for the overlay view

  I would not mind in creating a PR for the name consistency and auto dismissal. Any thoughts?

[saeid]

Hey @pgudivadaDiligent! Lib initially was named GDOverlay and that's the source of inconsistency in naming, It's my bad to forgot to fix it. I was really busy lately but thinking about some changes as well as auto dismiss you mentioned. It would be so great if you can submit a PR.

[pgudivadaDiligent]

Hi Saeid,

Will create a PR and submit the same for your review.

Thanks

Partha

From: Saeid Basirnia [email protected] Reply-To: saeid/SwiftyOverlay [email protected] Date: Thursday, October 31, 2019 at 6:54 AM To: saeid/SwiftyOverlay [email protected] Cc: Partha Gudivada [email protected], Mention [email protected] Subject: Re: [saeid/SwiftyOverlay] Naming convention/Auto Dismissal (#1)

Hey @pgudivadaDiligenthttps://github.com/pgudivadaDiligent! Lib initially was named GDOverlay and that's the source of inconsistency in naming, It's my bad to forgot to fix it. I was really busy lately but thinking about some changes as well as auto dismiss you mentioned. It would be so great if you can submit a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/saeid/SwiftyOverlay/issues/1?email_source=notifications&email_token=AMEEY3Z7VSMU3T24HU3PSALQRK2NVA5CNFSM4IYMPBV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECXJZJQ#issuecomment-548314278, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMEEY34544FVDFVLFC7YDF3QRK2NVANCNFSM4IYMPBVQ.