Maryam icon indicating copy to clipboard operation
Maryam copied to clipboard

Web interface for iris module latest version(2.5.2)

Open Moksh45 opened this issue 1 year ago • 27 comments

Fixes #

Resolves

add web interface for the iris module

Checklist

  • [x] I have read the Contribution & Best practices Guideline.
  • [x] My branch is up-to-date with the Upstream master branch.
  • [x] The acceptance, integration, unit tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation (if appropriate)

Moksh45 avatar Jun 22 '23 11:06 Moksh45

is it okay to have this error: sh: 1: react-scripts: not found What is the endpoint for the iris?

saeeddhqan avatar Jun 22 '23 21:06 saeeddhqan

react-scripts: not found," typically occurs when the react-scripts package is missing or not installed correctly. This package is required for running and building React applications.

  1. Please make sure that you have Node.js and npm (Node Package Manager) installed on your system.
  2. After running the command "pip install -e ." to set up Maryam, please navigate to the path "Maryam/core/web/web_interface" and verify the existence of the "node_modules" directory.

and When I try to run the web interface, no errors appear in my terminal.

Screenshot from 2023-06-23 10-55-43

Moksh45 avatar Jun 23 '23 05:06 Moksh45

What is the endpoint for the iris? I'm not sure what you're asking.

Moksh45 avatar Jun 23 '23 05:06 Moksh45

If Node.js is a requirement, please verify that it exists before running the server. If it does not exist, print a message.

saeeddhqan avatar Jun 23 '23 07:06 saeeddhqan

ok

Moksh45 avatar Jun 23 '23 07:06 Moksh45

I have completed all the necessary changes. Please take a moment to review the Pull Request again and verify the modifications. If you have any further feedback or suggestions, let me know. Thank you

Moksh45 avatar Jun 23 '23 08:06 Moksh45

Remove this section: image Remove this section: image This section is terrible: image Put the logo on the right side. And crop the logo like this: image The query should remain in the form. The search form has a pink square. Remove it. Use this color for the background: #000d02 And the black color for the header section: #000 Make the search form precisely like startpage.com. Remove icons from this section: image Add something like this to the footer, left side: image The color is #174d07. Change the title to Iris. Not Iris web interface. Please correct the home form too: image Change the home bc color to: #000d02. The home owasp logo is too big. Make it smaller and crop it as I said above.

saeeddhqan avatar Jun 23 '23 08:06 saeeddhqan

Ok I made All the changes

Moksh45 avatar Jun 23 '23 08:06 Moksh45

ss In this particular section, I am retaining the code in the code base but making use of the <Search hideShortCut /> feature.

the result looks like Screenshot from 2023-06-23 15-32-16

Moksh45 avatar Jun 23 '23 10:06 Moksh45

We do not need them. Not even in the future.

saeeddhqan avatar Jun 23 '23 17:06 saeeddhqan

ok, i will remove that specific part from the code base.

Moksh45 avatar Jun 23 '23 18:06 Moksh45

I have created a design for the search header field that I believe matches your requirements. If you approve the design, I will proceed with implementing it. WhatsApp Image 2023-06-24 at 1 37 01 AM

Moksh45 avatar Jun 23 '23 20:06 Moksh45

Put the logo at the far left side.

saeeddhqan avatar Jun 24 '23 06:06 saeeddhqan

like this! WhatsApp Image 2023-06-24 at 12 46 25 PM

Moksh45 avatar Jun 24 '23 07:06 Moksh45

Fine.

saeeddhqan avatar Jun 24 '23 07:06 saeeddhqan

I believe I have resolved all the errors in the UI and made the necessary updates to the web interface based on your suggestions. The final result looks like this.

Screenshot from 2023-06-24 23-12-42 image

I kindly request you review my pull request once again

Moksh45 avatar Jun 24 '23 17:06 Moksh45

Much better.

  1. Now, when I click on the search form, it shows a pink border. Resolve it. Make it like startpage.com, go to the website and when you click on the form, it shows a light purple color.
  2. Add an under construction section to the image tab or hide it.

saeeddhqan avatar Jun 26 '23 07:06 saeeddhqan

The search form now has a border added, and the image tab has been hidden on the search result page. Please review the pull request

Moksh45 avatar Jun 26 '23 08:06 Moksh45

I still see the pink border.

saeeddhqan avatar Jun 28 '23 07:06 saeeddhqan

Check this error: image

When I go to the http://localhost:3000/search without sending a request for the backend:

Screenshot from 2023-06-28 11-03-37 You need to redirect them to the index page. It's like going to the https://www.startpage.com/sp/search without a query.

saeeddhqan avatar Jun 28 '23 07:06 saeeddhqan

Alright, I'll change the border color of the search box to a light purple. Additionally, I'll fix the existing error. Lastly, I'll add the functionality to redirect users to the index page.

Moksh45 avatar Jun 28 '23 13:06 Moksh45

Apologies for accidentally clicking on the "Close PR"

Moksh45 avatar Jun 28 '23 13:06 Moksh45

Remove the pink rectangle please.

saeeddhqan avatar Jun 28 '23 17:06 saeeddhqan

I don't understand which pink rectangle you're referring to. Could you please share a picture or image of the pink rectangle with me?

Moksh45 avatar Jun 29 '23 04:06 Moksh45

I have made all the necessary adjustments based on your suggestions. Please review the changes accordingly

ss

I believe I have resolved this error, but could you please confirm if you encountered the same issue?

Moksh45 avatar Jun 30 '23 13:06 Moksh45

I still see the pink rectangle. And it does not show anything. I tried iris and it works but the web interface does not show anything.

saeeddhqan avatar Jul 17 '23 07:07 saeeddhqan

I have resolved the border issue. please check it

Moksh45 avatar Jul 17 '23 08:07 Moksh45