react-counter
react-counter copied to clipboard
Updated react version and moved to peer dependencies
When using react already in a project, modules should have react in peerDependencies so that it doesn’t get included twice and uses the already included instance. Also updated React version, don’t know if you want that anyway decided to send a PR ;)
Cheers bruno.
I've actually no experience publishing modules for react, but I'll get this (and #1) fixed ASAP. I'm building a project on react 0.12, so I wouldn't want that dep bump, and I see no reason for not supporting both if possible?
Hey,
Strange, tried changing the peerDependency to 0.12.2 but it gives me an error when installing on my project:
"The package react does not satisfy its siblings' peerDependencies requirements!"
It should match since I've put ^0.12.2 so it should match 0.13 http://stackoverflow.com/questions/22343224/difference-between-tilde-and-caret-in-package-json
Gonna try some things out
Cheers
I think this is it, added peerDependency "react": ">= 0.12", and it now works in my project, can you confirm on yours as well?