lsp-plugins icon indicating copy to clipboard operation
lsp-plugins copied to clipboard

Setting to use number 1 instead of 0 for items in GUI

Open audio2000 opened this issue 1 year ago • 2 comments

I noticed that these plugins use 0 instead of the number 1 to start off item lists. For example in the sampler plugins you see 0-7 for samples instead of 1-8. Can also be seen in EQ plugins as well. Not sure if anyone else would agree, I know this is common in computing approach, but this has always been confusing to me. Maybe can add a setting that can change this visually in all GUIs that contain this approach?

Again not sure if others would agree/find this useful Thank You

audio2000 avatar Aug 08 '24 18:08 audio2000

Thank you for adding this to the milestone. I didn't think anyone would care about this, thank you.

So far these are the plugins where I have seen this used in -Samplers / Multi-Samplers -EQs -Impulse Reverb

Sampler Plugins Not Important: I apologize if the following is confusing, but in the case of the LSP SAMPLER based plugins this could get tricky. I think this setting still would be beneficial but can understand more so of the benefit for the decision to use the 0 as “1” approach because unfortunately :) that is what MIDI uses as well. So with “Instrument" which are linked to MIDI Numbers then you can match the “Instrument 0” with "MIDI Number" 0. The “Sample” using this also could make sense as well because velocity does start at 0 in MIDI as well. But in the case of the “Sample” because it is more visually present in the plugin GUI, using 1-8 in my opinion would be easier for the user to understand / keep track of. In the case of the Sampler plugin numbering, developer would have to make this decision. Might be confusing to have two settings for this, one for “Instrument” and one for “Sample” but it could be helpful, but again might be confusing depending how this is applied. Anyways, hopefully some of this makes sense.

Thank You

audio2000 avatar Sep 02 '24 01:09 audio2000

Seems that @bor-T has completed all the job with renaming. Please not that it will only affect the UI, for backward-compatibility reason we don't rename parameters nor inputs/outputs.

sadko4u avatar Sep 12 '24 16:09 sadko4u

Done in 1.2.18.

sadko4u avatar Oct 08 '24 14:10 sadko4u

Tested, works/looks great. I did not see a way to change back to using 0s, so am I correct that this was just a decision that was decided to be the default as instead of a setting?

audio2000 avatar Oct 15 '24 21:10 audio2000

Yes, we just changed the numbering in the UI.

sadko4u avatar Oct 15 '24 23:10 sadko4u

Ah okay I just wanted to make sure I was not overlooking a setting to test, thank you guys again for making this update.

audio2000 avatar Oct 26 '24 00:10 audio2000