lsp-plugins icon indicating copy to clipboard operation
lsp-plugins copied to clipboard

Multisampler, wrong path stored inside cfg file

Open Daniele71 opened this issue 11 months ago • 5 comments

Hi, not sure if it's really wrong but... I was trying to retrive a full path of a sample, then I opened the cfg file that i made month ago. With big surprise, all samples path are pointing to my /home/$user/Ardour_Sessions/$session_name/plugins/59925/state14/$sample_name. $sample_name is a symlink to Ardour externals dir where $sample_name is another symlink to real sample.

Is this correct ? I'm sure that I already did this operation in the past and there was the real path.

lsp-plugin 1.2.15 lv2 from proaudio repo on openSUSE TW

Thanks.

Daniele71 avatar Mar 16 '24 18:03 Daniele71

Hello! LSP Plugins use LV2 mapPath feature which is required for making sessions portable between computers. The responsibility of creating symbolinc links or files is delegate to the host application.

When the LV2 plugin saves the state, it is required to call abstract_path function to make the DAW do the usual job. When the plugin restores the state from the session, it uses the path the DAW returns to it when calling the absolute_path function.

Please consider looking following threads: https://github.com/lsp-plugins/lsp-plugins/issues/386 https://github.com/lsp-plugins/lsp-plugins/issues/119 https://github.com/lsp-plugins/lsp-plugins/issues/118 https://github.com/lsp-plugins/lsp-plugins/issues/132

sadko4u avatar Mar 16 '24 18:03 sadko4u

I don't know... cfg file should stay with full path to sample. What if I delete the the ardour session dir and move to another DAW ? All my custom kit become trash ?!? This is wrong, IMHO.

Daniele71 avatar Mar 16 '24 19:03 Daniele71

OK, this is reasonable.

sadko4u avatar Mar 16 '24 21:03 sadko4u

Thanks !

Daniele71 avatar Mar 16 '24 21:03 Daniele71

I've just committed changes to devel branches of all affected sub-projects and tested. Now the path provided by Ardour is properly converted to the path to the original file. You can build from devel branch and verify.

sadko4u avatar Mar 17 '24 00:03 sadko4u

Fixed in 1.2.16!

sadko4u avatar May 22 '24 21:05 sadko4u