socketcluster-client-java icon indicating copy to clipboard operation
socketcluster-client-java copied to clipboard

Published 20 hours ago • verified publisher icon sacOO7

Avoid creating new socket every time on connectAsync

Open angelix opened this issue 6 years ago • 9 comments

For every call to connect/connectAsync there is a new ws socket created, leaving the previous one connected but orphaned. This PR, allow only one instance of Socket to be actively connected at any time.

angelix avatar Aug 19 '18 17:08 angelix

Hi @angelix , I am not sure if it creates new connection everytime.... I am sure, it will close the previous socket (The reason why new one is created). Still, will look into it. Thank you for the PR.

sacOO7 avatar Aug 19 '18 19:08 sacOO7

My server had a new connection for every connectAsync from the client. If you take a look at the code, it just replace ws with new Socket every time. Thanks @sacOO7

angelix avatar Aug 19 '18 19:08 angelix

Hey, will be looking into it. Little busy those days ...

sacOO7 avatar Aug 21 '18 09:08 sacOO7

Did you have the time to test this @sacOO7 ? Thanks

angelix avatar Sep 15 '18 09:09 angelix

Hi @sacOO7 , When can you release a new version of the lib with the fixes? Thanks

angelix avatar Oct 05 '18 11:10 angelix

Hi @sacOO7 , When can you release a new version of the lib with the fixes? Thanks

angelix avatar Jan 06 '19 10:01 angelix

Hi @sacOO7 It's being over 6 months for this PR to get merged or release a new version. Do you need any help?

angelix avatar Apr 18 '19 10:04 angelix

@sacOO7 ? :(

angelix avatar Aug 20 '19 14:08 angelix

Hey @angelix , will be looking into this

sacOO7 avatar Apr 10 '20 13:04 sacOO7