vobject icon indicating copy to clipboard operation
vobject copied to clipboard

Add support for COMMENT property

Open miaulalala opened this issue 2 years ago • 1 comments

RFC5546 allows for COMMENT properties on all iTIP methods. This PR attempts to extend the current implementation to suppot COMMENTs on REQUEST, REPLY and CANCEL methods currently implemented in the Broker.

Signed-off-by: Anna Larch [email protected]

miaulalala avatar Sep 23 '22 23:09 miaulalala

Codecov Report

Merging #593 (23d36a9) into master (7c585e6) will decrease coverage by 0.25%. The diff coverage is 42.10%.

@@             Coverage Diff              @@
##             master     #593      +/-   ##
============================================
- Coverage     98.53%   98.27%   -0.26%     
- Complexity     1865     1876      +11     
============================================
  Files            71       71              
  Lines          4159     4178      +19     
============================================
+ Hits           4098     4106       +8     
- Misses           61       72      +11     
Impacted Files Coverage Δ
lib/ITip/Broker.php 96.82% <42.10%> (-2.67%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 24 '22 06:09 codecov[bot]

Closing this as we're going to go a different route with comments

miaulalala avatar Nov 21 '22 16:11 miaulalala