vobject icon indicating copy to clipboard operation
vobject copied to clipboard

Empty TZID

Open armetiz opened this issue 7 years ago • 7 comments

One of our customer export ICS from "Microsoft Corporation//Outlook 14.0 MIMEDIR//EN" Configured TZID is empty..

BEGIN:VTIMEZONE
TZID:
BEGIN:STANDARD

This commit allow a fallback to the default timezone value instead of a PHP fatal error.

armetiz avatar May 05 '17 08:05 armetiz

I just forked from master.. The error is not under my control.

armetiz avatar May 05 '17 08:05 armetiz

any news ?

armetiz avatar Oct 19 '17 13:10 armetiz

Can we get a unit test on this? THX

DeepDiver1975 avatar Sep 25 '18 07:09 DeepDiver1975

Hi there.

I'm sorry, I have no time to add unit test for this.

Regards.

armetiz avatar Sep 25 '18 08:09 armetiz

test added.

armetiz avatar Jun 02 '20 12:06 armetiz

Codecov Report

Merging #375 (2642abe) into master (d8a0a9a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #375   +/-   ##
=========================================
  Coverage     98.73%   98.73%           
- Complexity     1759     1760    +1     
=========================================
  Files            66       66           
  Lines          4279     4279           
=========================================
  Hits           4225     4225           
  Misses           54       54           
Impacted Files Coverage Δ Complexity Δ
lib/TimeZoneUtil.php 97.67% <100.00%> (ø) 24.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8a0a9a...2642abe. Read the comment docs.

codecov[bot] avatar Jun 03 '20 08:06 codecov[bot]

patch have be rebase.

armetiz avatar Apr 30 '21 13:04 armetiz