sabre.io icon indicating copy to clipboard operation
sabre.io copied to clipboard

Deploy to Website

Open smainz opened this issue 4 years ago • 21 comments
trafficstars

In April my PR #134 regarding outdated docker install instructions has been accepted, but on the Website there still is the old version.

Can anyone please depoy this?

smainz avatar Jun 16 '21 17:06 smainz

@DominikTo I guess you are the only one with the required credentials

staabm avatar Jun 16 '21 17:06 staabm

Ah, damn. That reminds me that I wanted to automate this. Will trigger a deploy shortly and report back here.

DominikTo avatar Jun 16 '21 18:06 DominikTo

Done.

DominikTo avatar Jun 16 '21 21:06 DominikTo

Thanks

smainz avatar Jun 18 '21 09:06 smainz

Ah, damn. That reminds me that I wanted to automate this.

Any news on automation? Has this been taken care of? Also to reduce the bus factor here: who else can do the deployment? THX

DeepDiver1975 avatar Sep 30 '22 08:09 DeepDiver1975

Will take care of it.

DominikTo avatar Sep 30 '22 08:09 DominikTo

Will take care of it.

THX a lot - as an more open approach we could move the site over to github pages.

I can look into the technical side if this is of interest.

DeepDiver1975 avatar Sep 30 '22 08:09 DeepDiver1975

@DominikTo does the web site auto-deploy these days when this repo changes? (I will make some small change anyway, and see if any "magic" happens)

phil-davis avatar Aug 18 '23 04:08 phil-davis

It sadly does not and I didn't get around yet to get the deploy script up and running locally again.

DominikTo avatar Aug 18 '23 07:08 DominikTo

due to #157 we have an autodeployed site again on https://sabre-io.github.io/sabre.io/

@DominikTo let's chat on how to redirect https://sabre.io to github pages - thx

DeepDiver1975 avatar Nov 09 '23 16:11 DeepDiver1975

having it as a github pages site is perfect, thank you!

staabm avatar Nov 09 '23 17:11 staabm

if we are fine to have it pure under https://sabre-io.github.io/sabre.io/ - some hard coded links within the source code need adaptation.

DeepDiver1975 avatar Nov 09 '23 17:11 DeepDiver1975

Doesn't that break external links, search engines, etc? Can't we set the dns of sabre.io to GitHub, so it stays on the same domain?

ByteHamster avatar Nov 09 '23 18:11 ByteHamster

We for sure can do that.... We = @DominikTo

DeepDiver1975 avatar Nov 09 '23 18:11 DeepDiver1975

Oh this is great! The old deploy script would have needed quite significant updates to work again. Let me check on setting up the domain for GH pages.

DominikTo avatar Nov 14 '23 12:11 DominikTo

@DeepDiver1975:

DNS is now hooked up for this repo/org. But GH UI added the CNAME file to the gh-pages branch when adding the domain, guess that should move into the master branch, so it gets added for deploys. And seems like links need to be updated. On the currently live page all links go to the github.io URL instead of sabre.io

DominikTo avatar Nov 14 '23 14:11 DominikTo

And seems like links need to be updated. On the currently live page all links go to the github.io URL instead of sabre.io

yes - will take care asap

DeepDiver1975 avatar Nov 14 '23 14:11 DeepDiver1975

But GH UI added the CNAME file to the gh-pages branch when adding the domain, guess that should move into the master branch, so it gets added for deploys.

will have a look as well ....

DeepDiver1975 avatar Nov 14 '23 14:11 DeepDiver1975

will have a look as well ....

@DominikTo have you setup the DNS records a defined in https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages ?

DeepDiver1975 avatar Nov 14 '23 15:11 DeepDiver1975

Yes, but interestingly enough the UI did not give me a TXT record for verification. Saw "DNS verified" straight away and it committed the CNAME file into the gh-pages branch.

If non-async is easier: Available via Twitter DM or on Matrix.

DominikTo avatar Nov 14 '23 15:11 DominikTo

Just realized that adding domain to GH pages and verifying are two separate processes. Now also verified for sabre-io org.

DominikTo avatar Nov 14 '23 15:11 DominikTo

I tried fixing something in the docs - PR #164 It was published on merge correctly, good. So we are able to update documentation and publish it nowadays.

phil-davis avatar May 24 '24 06:05 phil-davis

This seems to be working. So I will close the issue. Feel free to re-open if there is more needed to be done.

(of course the actual docs content needs to be got up-to-date, but that is a separate task!)

phil-davis avatar May 24 '24 07:05 phil-davis