katana
katana copied to clipboard
I dockerized your app
Very needed tool, thanks for writing it!
not well enough...
Thanks for the PR!
Actually I am changing it to use php7.
Basically I was testing out hhvm because I had heard it was fast.
I'll have another crack at it now.
-Jake On Aug 15, 2015 5:18 PM, "Ivan Enderlin" [email protected] wrote:
Thanks for the PR!
— Reply to this email directly or view it on GitHub https://github.com/fruux/sabre-katana/pull/288#issuecomment-131325225.
Allow root because docker images build as root. On Aug 16, 2015 10:44 AM, "Jacob Gadikian" [email protected] wrote:
Actually I am changing it to use php7.
Basically I was testing out hhvm because I had heard it was fast.
I'll have another crack at it now.
-Jake On Aug 15, 2015 5:18 PM, "Ivan Enderlin" [email protected] wrote:
Thanks for the PR!
— Reply to this email directly or view it on GitHub https://github.com/fruux/sabre-katana/pull/288#issuecomment-131325225.
Neither PHP7 nor HHVM are currently fully supported unfortunately. For this to be accepted it should run on PHP 5.6.
@evert sabre/dav does not support PHP7 yet? I thought yes since a recent release.
I'll change it up. Sorry for the delays on my end.
Thanks!
-Jake
Jacob Gadikian E-mail: [email protected] SKYPE: faddat Phone/SMS: +84 167 789 6421
On Tue, Aug 18, 2015 at 12:37 PM, Ivan Enderlin [email protected] wrote:
@evert https://github.com/evert sabre/dav does not support PHP7 yet? I thought yes since a recent release.
— Reply to this email directly or view it on GitHub https://github.com/fruux/sabre-katana/pull/288#issuecomment-132076786.
Not even sure why I went for HHVM/PHP7 the first time around. Will submit again with 5.6 :).
@Hywan , next major releases will support PHP 7. So vobject 4 and sabre/dav 3.1.
@evert: Oh yes, correct, remember the discussion now. Thanks.
Would you have some brief instructions on how to test this on OS X? I don't have a lot of experience with docker. I'm pretty sure I have this container up and running, but I have no idea how to connect to port 80 of the container.