dav icon indicating copy to clipboard operation
dav copied to clipboard

Incorrect default value for time-range CalDAV PropFilter

Open simonspa opened this issue 5 years ago • 3 comments

Currently, the default value for time-range in a CalDAV request is set to false here: https://github.com/sabre-io/dav/blob/master/lib/CalDAV/Xml/Filter/PropFilter.php

This does not seem to comply with https://tools.ietf.org/html/rfc4791#section-9.9, but it should rather be an empty array.

simonspa avatar Oct 23 '20 09:10 simonspa

I believe KDE Kontact/Kalendar users also see this problem.

rriemann avatar Nov 12 '20 08:11 rriemann

@simonspa @rriemann could you clarify what the consequence for this bug for the end user is?

staabm avatar Nov 16 '21 09:11 staabm

@staabm none for the end users, but libraries using the DAV library can rely on RFC-4791-compliant handling of time ranges. According to the RFC, the value has to be set to an empty array in case no range is set, not to a false value.

Most downstream libraries probably catch this behavior, but I've seen instances (down at ownCloud, Nextcloud) where this leads to errors for example when syncing with third-party apps such as DAVx5 which implement RFC4791 more strictly.

simonspa avatar Nov 16 '21 09:11 simonspa