dav icon indicating copy to clipboard operation
dav copied to clipboard
verified publisher icon sabre-io

Add logging example implementation to groupwareserver

Open Yannik opened this issue 5 years ago • 5 comments

As per #806

Yannik avatar Feb 05 '20 20:02 Yannik

@Yannik this needs some formatting to keep php-cs-fixer happy - see Travis CI fails https://travis-ci.org/sabre-io/dav/jobs/646593845?utm_medium=notification&utm_source=github_status

phil-davis avatar Feb 06 '20 02:02 phil-davis

@phil-davis Should be fixed now.

Yannik avatar Apr 21 '20 12:04 Yannik

@phil-davis Should be fixed now.

actually not - see travis output

DeepDiver1975 avatar Apr 22 '20 06:04 DeepDiver1975

@DeepDiver1975 I think this is a php-cs-fixer error. Firstly, I'd like to note that this change was not suggested by PHPStan during the earlier (OP) build (https://travis-ci.org/github/sabre-io/dav/jobs/646593845)

Secondly, please have a look at the suggested change (https://travis-ci.org/github/sabre-io/dav/jobs/677680657#L367):

-/**
+/*

This doesn't really make sense in that place. All the other comments are of format /**, too.

Yannik avatar Apr 22 '20 09:04 Yannik

CI is failing in all PRs - I raised issue #1266 I will look.

phil-davis avatar Apr 22 '20 09:04 phil-davis