dav
dav copied to clipboard
Support for Chunked Encoding in nginx, comment in code true? not true?
First of all , great project! keep up the fine work!
Yesterday I was stepping through the code learning more about the stack, and I came across this commit from 2012
https://github.com/sabre-io/dav/commit/a50b0df77 @evert
// If nginx (pre-1.2) is used as a proxy server, and SabreDAV as an
// origin, we must make sure we send back HTTP/1.0 if this was
// requested.
// This is mainly because nginx doesn't support Chunked Transfer
// Encoding, and this forces the webserver SabreDAV is running on,
// to buffer entire responses to calculate Content-Length.
But I remember that this option exists in nginx since about 2013..
http://nginx.org/en/docs/http/ngx_http_core_module.html#chunked_transfer_encoding
Maybe I misunderstand the statement here "This is mainly because nginx doesn't support Chunked Transfer Encoding", is it saying "below nginx 1.2 it is not supported" ? that comment was written before 2013..
Thoughts? what is the situation with Sabre and chunked encoding?
Thanks
The comment meant that nginx versions older than 1.2 would break. Does that answer your question?