Baikal
Baikal copied to clipboard
sabre-io
Globally change # comments to //
Is there any interest in changing ALL the comments in all PHP files from # to //? If so then I'd be prepared to have a go at it.
I was in the middle of trying to provide a reason when you closed the issue. The only tangible benefit is summed up in this quote from the php-fig repo where none of the code examples use a hash.
The intent of this guide is to reduce cognitive friction when scanning code from different authors. It does so by enumerating a shared set of rules and expectations about how to format PHP code.
https://github.com/php-fig
Okay, so that's not quite a "won't fix" so would you object to a patch that globally converted all # chars to a more conventional // ?
It certainly had an impact on me when I tried to read through the code. Dare I say "it made my eyes bleed" seeing all those # chars. It's not only a personal preference thing but, as that quote points out, it would help to "reduce cognitive friction."
It's probably worthwhile just running the same CI / prettify rules as all the other sabre/* projects and have this done automatically.
