lex icon indicating copy to clipboard operation
lex copied to clipboard

Refering to commit "use concatenated strings instead of repeated printfs".

Open sighook opened this issue 5 years ago • 1 comments

Hi rofl0r,

Here you change many fprintf calls to one. And, as far as I see, in the old code, only the first instruction will be executed after the else statement. After the patch, the behavior is different.

I looked Ilumos and did not find any differences from the old code.

Unfortunately, I do not understand the code to say for sure. But I believe that the original developers forgot the indentation, not the curly braces. What do you think about this?

P.S. Huge thanks for what you're doing.

sighook avatar May 07 '20 14:05 sighook

hi, sorry for the late reply. in the line you highlighted i can't see any codechanges regarding if/else statements. did you mean to highlight another line?

rofl0r avatar Jul 05 '20 17:07 rofl0r