php-eldoc
php-eldoc copied to clipboard
Feedback on ELPA packaging
A few points of feedback having read through the code:
- Perhaps it would even be possible to invoke
probe.php
using the command-linephp
executable and adjusting the PHPinclude_path
to point at the project being inspected. - You should also include some
;;;###autoload
cookies, at least forphp-eldoc-enable
, and I'd also suggest autoloading the setup hook:
;;;###autoload
(add-hook 'php-mode 'php-eldoc-enable)
-
ac-sources
is not buffer-local, so you shouldn't addac-source-php-eldoc
to it every timephp-eldoc-enable
is called; either makeac-sources
buffer-local, or just add the source once at global scope. (Making the var buffer local would be preferable IMO.)
Hope that helps!
-Steve