v2-core icon indicating copy to clipboard operation
v2-core copied to clipboard

Regenerate SMTChecker report

Open PaulRBerg opened this issue 2 years ago • 7 comments

Investigate why it is failing:

https://github.com/sablier-labs/v2-core/actions/runs/6213048327

PaulRBerg avatar Oct 12 '23 13:10 PaulRBerg

@andreivladbrg I would really like to generate this SMTChecker report before the audits start in November. Can you please work on this task?

PaulRBerg avatar Oct 19 '23 11:10 PaulRBerg

yes, next on my list

andreivladbrg avatar Oct 19 '23 11:10 andreivladbrg

I've been attempting to compile this full report for a couple of days now, but it simply won't complete. I even left my laptop on overnight to run the full report, but it didn't work for the lockupDynamic contract.

I'll leave the report for the linear contract below:

smtchecker-report-linear.txt

The result is odd, especially given that we have this configuration: https://github.com/sablier-labs/v2-core/blob/91887daff5872c7fa83fe3644b6f7582e9bffc0d/foundry.toml#L55-L57

I suspect this issue is related to the new Solidity version 0.8.21 we are using, it might not be fully supported yet.

andreivladbrg avatar Oct 21 '23 13:10 andreivladbrg

I was expecting the report generation to take a long time.

But yes, the report is strange.

Don't worry in this case, I will pick up this task later. Thanks for your help.

PaulRBerg avatar Oct 27 '23 15:10 PaulRBerg

We should upload the SMTChecker report in the docs.

PaulRBerg avatar Nov 23 '23 15:11 PaulRBerg

This issue is stale because it has been open 182 days with no activity. Leave a comment or remove the "stale" label, otherwise this will be closed in 14 days.

github-actions[bot] avatar Jul 07 '24 03:07 github-actions[bot]

I'll handle this

PaulRBerg avatar Jul 07 '24 06:07 PaulRBerg

This issue is stale because it has been open 182 days with no activity. Leave a comment or remove the "stale" label, otherwise this will be closed in 14 days.

github-actions[bot] avatar Jan 12 '25 03:01 github-actions[bot]

OK, let's close this.

I'm hopeful that someday, we will find the time to properly explore SMTChecker.

PaulRBerg avatar Jan 13 '25 09:01 PaulRBerg