docs icon indicating copy to clipboard operation
docs copied to clipboard

Enable Vercel Analytics

Open PaulRBerg opened this issue 2 years ago • 8 comments

SCR-20240201-smem

PaulRBerg avatar Feb 01 '24 19:02 PaulRBerg

We would have to implement a cookie banner to enable these analytics, wouldn't we, @razgraf, @gavriliumircea?

PaulRBerg avatar Feb 06 '24 10:02 PaulRBerg

Yus but we should use the cookie banner that we already have

gavriliumircea avatar Feb 06 '24 10:02 gavriliumircea

Got it. Would it be difficult to port that over to this repository?

Related: https://github.com/sablier-labs/v2-interfaces/discussions/454

PaulRBerg avatar Feb 06 '24 10:02 PaulRBerg

First of all we don't actually have a roadmap for the sdk. Further more we will be able to put there the component itself but the entire cookies system is a different discussion, we have a store related to those, config function, project keys so the complexity is increasing exponentially.

gavriliumircea avatar Feb 06 '24 10:02 gavriliumircea

First of all we don't actually have a roadmap for the sdk

I know. When I add related links, I just put it there for historical association reasons - not to push it as a high-priority item today.

Further more we will be able to put there the component itself but the entire cookies system is a different discussion

Surely we can have a minimal component just for the Vercel analytics and Crisp? We don't need Sentry and Mixpanel and the other stuff in the docs.


Maybe Docusaurus has a pre-fab solution for cookies? More research needed.

PaulRBerg avatar Feb 06 '24 10:02 PaulRBerg

We should discuss this in the call we have next week.

gavriliumircea avatar Feb 06 '24 10:02 gavriliumircea

Worth noting that the SDK isn't very related to this discussion. The SDK would include Sablier branded elements (UI or flows) for integrators to use.

The "legal" components like any other very opinionated functionalities (like the cookie banner) would most likely not live in an SDK. Maybe in a shared internal components package (but we have that for now in the interfaces monorepo).


Looks like Vercel Analytics should be valid for an integration with Docusaurus. There's still the question of what the best approach is e.g., injecting the Analytics RC and handling beforeSend like in the app vs. using the plugin vs. other

Related links:

  • https://github.com/facebook/docusaurus/discussions/9079
  • https://github.com/facebook/docusaurus/discussions/8176
  • https://github.com/gracefullight/docusaurus-plugins?tab=readme-ov-file

razgraf avatar Feb 06 '24 13:02 razgraf

Worth noting that the SDK isn't very related to this discussion. ... The "legal" components like any other very opinionated functionalities (like the cookie banner) would most likely not live in an SDK

You're right.

Looks like Vercel Analytics should be valid for an integration with Docusaurus

Nice

PaulRBerg avatar Feb 06 '24 14:02 PaulRBerg