BandcampEnhancementSuite icon indicating copy to clipboard operation
BandcampEnhancementSuite copied to clipboard

Non-Bandcamp Domains Blocked

Open sabjorn opened this issue 3 years ago • 4 comments

Bandcamp allows for custom domains and because the manifest for the extension is only wildcarded to "*.bandcamp.com", these don't work.

A user suggested adding the ability to choose custom domains BUT this still requires the manifest to wildcard to all domains. This could be a problem with the review process for publishing.

sabjorn avatar Sep 23 '21 16:09 sabjorn

Some extensions do operate on full wildcard: most adblockers, Tampermonkey, etc. It should be possible to get past review with a wildcard, but you're right in that the reviewer could request changes.

Something to consider will be the extension footprint when loading on other domains. Does the extension rely on certain elements (JSON blobs, particular IDs) or libraries (jQuery) being present in the DOM? When the extension initializes, does it load all of its bundled code into the runtime? Is there a way to structure JS functions and closures in a way that doesn't load or get parsed immediately, so that the extension can minimize its impact on pages where it isn't required?

Ensuring the extension plays nicely on all pages is responsible 👍

emcniece avatar Sep 23 '21 16:09 emcniece

@emcniece very good question. Currently the "main" of the application will at least skip code execution if certain components are not present on the page (sometimes it's a url matching, other times it's checking for an element on the page).

So, yeah, I think everything loads on runtime but execution is limited. We should investigate this next time we hang out.

sabjorn avatar Oct 02 '21 18:10 sabjorn