Add : Dark mode

[sabesansathananthan]

Add Dark Mode to this GUI. Users can change the mode manually by using the toggler. Should use Material-UI components.

[mayank]

I will do this. Assign it to me.

[sabesansathananthan]

Sure. Don't forget to star this repo.

[esau-morais]

@mayank , please, give a feedback about the issue

Note: If it takes more than one week, we must close this issue

[sabesansathananthan]

I personally suggest using Style components rather than using other libraries like darkmode.js

[mayank]

The code is not written properly to add dark mode. You have to refactor a lot of code. Each component will have its own dark mode css. You should document the color scheme.

[esau-morais]

The code is not written properly to add dark mode. You have to refactor a lot of code. Each component will have its own dark mode css. You should document the color scheme.

I agree with @sabesansathananthan and it's not a good practice just use other package (like you are doing) to add dark mode. You can use a provider by styled-components.

Note: How the code is not written to add dark mode? Any code will need to be refactored to add some feature. And if you use a provider, you'll probably will not need too much editions.

Note 2: Please, notice that we are trying just to advice you about the best practices

[mayank]

You need to follow theme for the project. Read this article for better understanding. https://medium.com/chequer/themes-in-react-js-for-vietnam-friends-100ccb334bcb

Then you create two themes one light and one dark.

Note: Please stop adding notes.

[mayank]

If you guys can add the theme for light mode, I will share PR for dark mode. It's actually too much work to rewrite all of that, so I am avoiding it. 🤞

[esau-morais]

If you guys can add the theme for light mode, I will share PR for dark mode. It's actually too much work to rewrite all of that, so I am avoiding it.

Thank you for noticing this!

Note: I can try, but I am just a contributor too. @sabesansathananthan is the project owner

[sabesansathananthan]

@mayank If this comment thread is disturbing to you please unsubscribe. Here we are talking about Best practices, not an easy way to achieve the dark mode. Here we try to follow the best practices mentioned in this article.

I personally suggest using Style components rather than using other libraries like darkmode.js

The above quote is for future developers who try to contribute to this issue, not for you.

Finally, Each one has freedom of speech so we can't say that 'don't add Notes '. For a healthy conversation, we are hearing all of your suggestions. Please respect others.

[mayank]

OK.