saber icon indicating copy to clipboard operation
saber copied to clipboard

fix: Fixes problem with moving Selection and not updated strokes

Open QubaB opened this issue 10 months ago • 6 comments

Commit 40116c53ed71517cfc2571ef1129e4ea9189bb49 created problem, that when selection is moved, selected paths are not moved together.

Fixes #1394, #1401, #1414

QubaB avatar Feb 15 '25 18:02 QubaB

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.15%. Comparing base (7d60459) to head (ffa0303). Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
lib/components/canvas/_stroke.dart 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
- Coverage   47.15%   47.15%   -0.01%     
==========================================
  Files         114      114              
  Lines        9002     9003       +1     
==========================================
  Hits         4245     4245              
- Misses       4757     4758       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 11 '25 13:03 codecov[bot]

Works for me on Galaxy Tab S7FE without and problems

ComputerElite avatar Mar 24 '25 11:03 ComputerElite

I can confirm that it works.

serackhlx avatar Mar 27 '25 19:03 serackhlx

Worked on Galaxy Tab S6 Lite 2020

rezyfr avatar Apr 14 '25 00:04 rezyfr

This should be merged as soon as possible @adil192

Gian-Fr avatar Apr 19 '25 10:04 Gian-Fr

Please @adil192 merge this , it will be so helpful

siure avatar Apr 25 '25 15:04 siure

@adil192 This bug should be resolved on priority basis. Its been difficult for months taking notes. Please merge ASAP.

abulusky avatar May 09 '25 14:05 abulusky

thank you @QubaB!

Update: I found another fix which means we don't need to recalculate paths every time

adil192 avatar May 12 '25 07:05 adil192