saber-notes
S-Pen button switches tool to Erase, but not erasing
Before submitting an issue, please check the following
- [X] I have searched for similar issues (both open and closed) and cannot find a duplicate
- [X] I agree to follow the Code of Conduct
Describe the bug
Newly introduced handling of S-Pen button pres (when howering pen) #1355 does not work correctly to me.
When I press S-Pen button, Eraser tool is activated on toolbar, but entities are not erased.
To reproduce
- Draw some entities
- Press S-Pen button (when pen is howered above screen) - Eraser activates
- Try to erase some items
Expected behavior
When Eraser is activated it should erase items
Saber version
v0.25.3
Device
- Device: Samsung Galaxy Tab S6
- OS: Android 13
Anything else?
No response
Same problem on a galaxy tab S4, and cannot update it above Android 10 so I'm stuck with being unable to use the stylus button...
This actually works partially in version 0.25.1, but was broken in 0.25.2. In 0.25.1 you have to press the button after putting the pen on the screen to start erasing.
However, starting with 0.25.2 eraser does not work at all.
Same issue at v0.25.2 (F-Droid) on Samsung Tab S6 Lite.
- If the stylus button is pressed before the stylus touches the screen: toolbar shows that the eraser is enabled, but touching the screen with the stylus has no effect.
- If the stylus button is pressed after the stylus touches the screen: toolbar shows that the eraser is enabled, and touching the screen with the stylus erases objects.
After upgrading to v0.26.2, the eraser has no effect no matter whether the button is pressed before or after touching the screen.
