saber icon indicating copy to clipboard operation
saber copied to clipboard

feat: Add better support for stylus hovering

Open 3akev opened this issue 1 year ago • 1 comments

This PR adds handlers for hovering stylus events, which are used to switch to the eraser tool when the stylus button is pressed while hovering.

This replaces the old functionality where pressing the stylus button mid-stroke removes the stroke, making it more in-line with other note applications and (in my opinion) more user friendly.

Closes #859

3akev avatar Sep 19 '24 08:09 3akev

Codecov Report

Attention: Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.

Project coverage is 47.34%. Comparing base (2815bad) to head (ba30f2d). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/editor/editor.dart 23.52% 13 Missing :warning:
lib/components/canvas/canvas_gesture_detector.dart 20.00% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   47.39%   47.34%   -0.05%     
==========================================
  Files         114      114              
  Lines        8959     8976      +17     
==========================================
+ Hits         4246     4250       +4     
- Misses       4713     4726      +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 19 '24 08:09 codecov[bot]

This looks good from the code. What device/s have you tested with? iirc pressing the S-pen button while hovering made the stylus not work temporarily

adil192 avatar Nov 10 '24 00:11 adil192

This looks good from the code. What device/s have you tested with? iirc pressing the S-pen button while hovering made the stylus not work temporarily

I tested this on a Galaxy S6 Lite with the S-pen. Unfortunately I don't have access to another device with a stylus, so I can't test this further. It should work on other devices, though.

3akev avatar Nov 11 '24 17:11 3akev

Tested on Samsung Galaxy Tab S7 FE with Samsung pen. Works great

ComputerElite avatar Nov 27 '24 15:11 ComputerElite

Thanks!

adil192 avatar Dec 14 '24 02:12 adil192

On my Galaxy Tab S6 is tool changed to Eraser when pressed button, but entities are not erased. So it does not work.

Does erasing work for you? I am using official relase 0.25.3.

QubaB avatar Dec 14 '24 11:12 QubaB

On my Galaxy Tab S6 is tool changed to Eraser when pressed button, but entities are not erased. So it does not work.

Does erasing work for you? I am using official relase 0.25.3.

I just tested the latest release, 0.25.3 on Galaxy S6 Lite. It appears to be working. Seems this is a rather sneaky bug. Maybe open an issue for it?

3akev avatar Dec 14 '24 12:12 3akev

I have found, that Preference "Automatically switch off Eraser" (do not know precise English name) does not work on my Saber 0.25.3. Even if this preference is switched On or Off, previous tool is used immediately after use of Eraser. I do not know if it can be connected.

QubaB avatar Dec 14 '24 16:12 QubaB