saber icon indicating copy to clipboard operation
saber copied to clipboard

feat: Customizable toolbar button size

Open QubaB opened this issue 1 year ago • 2 comments

Implemented 3 different sizes of toolbar buttons to allow user to choose smaller buttons if toolbar takes too big area of screen.

Closes #1146
also partialy closes #1177 (here probably the possibility to hide toolbar when typing text will be better solution - for example long press on text toolbar button)

QubaB avatar Mar 18 '24 19:03 QubaB

Codecov Report

Attention: Patch coverage is 37.61468% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 37.56%. Comparing base (5b64bd8) to head (a6b285d). Report is 86 commits behind head on main.

:exclamation: Current head a6b285d differs from pull request most recent head a58825e. Consider uploading reports for the commit a58825e to get more accurate results

Files Patch % Lines
lib/pages/home/settings.dart 0.00% 29 Missing :warning:
lib/components/toolbar/toolbar_button.dart 50.00% 15 Missing :warning:
lib/components/toolbar/pen_modal.dart 0.00% 6 Missing :warning:
lib/components/toolbar/size_picker.dart 0.00% 6 Missing :warning:
lib/components/toolbar/toolbar.dart 58.33% 5 Missing :warning:
lib/components/toolbar/color_bar.dart 73.33% 4 Missing :warning:
lib/data/prefs.dart 66.66% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
+ Coverage   37.49%   37.56%   +0.06%     
==========================================
  Files         108      108              
  Lines        8564     8668     +104     
==========================================
+ Hits         3211     3256      +45     
- Misses       5353     5412      +59     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 18 '24 19:03 codecov[bot]

I probably did not choosed the best way. If you @adil192 tell me how to do it better, I rewrite code.

I would like to have this option. Now my toolbar takes up two lines.

QubaB avatar Mar 19 '24 05:03 QubaB