Images randomly getting replaced or emptied when adding more images

[nicholasbrantley]

Before submitting an issue, please check the following

• [X] I have searched for similar issues (both open and closed) and cannot find a duplicate
• [X] I agree to follow the Code of Conduct

Describe the bug

In the iPad app, when adding images to a page, random existing images on other pages will be replaced with one of the newly added images while retaining original aspect ratio, or will be emptied out and become a transparent square.

To reproduce

Seems to occur randomly, but happens when there are images already in the document, and after you add multiple new images to a page.

Expected behavior

The existing images should not be getting replaced or emptied.

Saber version

0.20.3 App Store (20030)

Device

iPadOS 17.4, iPad Air 3

Anything else?

No response

[QubaB]

Are there problems when "quickly" going to another page and adding an image on that page? Or it occurs during normal "slow work" on one page?

I haven't been able to replicate behavior described by you (ion Android), but it may be related to issue #1066. I created pull request #1128. May be it solve also your problem.

When you move to another page, images on not visible page are removed from memory. And if the note is saved (or autosaved) at the same moment, images can disappear (I observed this only on pdf background images) or can be reordered (I did not observed this). It is why I asked for "slow" of "quick" movement.

[nicholasbrantley]

Are there problems when "quickly" going to another page and adding an image on that page? Or it occurs during normal "slow work" on one page?

I haven't been able to replicate behavior described by you (ion Android), but it may be related to issue #1066. I created pull request #1128. May be it solve also your problem.

When you move to another page, images on not visible page are removed from memory. And if the note is saved (or autosaved) at the same moment, images can disappear (I observed this only on pdf background images) or can be reordered (I did not observed this). It is why I asked for "slow" of "quick" movement.

I tried messing with it and doing it quickly but could not get it to happen intentionally. I don't think I was doing it in a quick manner when it would happen. However I also ran into a bug where if I deleted a note with images, and created a new one and added images to it, it would show the images of the deleted one instead of what I added.

[QubaB]

I tried messing with it and doing it quickly but could not get it to happen intentionally. I don't think I was doing it in a quick manner when it would happen.

So probably unrelated to #1066.

However I also ran into a bug where if I deleted a note with images, and created a new one and added images to it, it would show the images of the deleted one instead of what I added.

Saber stores images in files "name of note".X where X is number. All I can think of is that before Saber deleted the files from the deleted note, you managed to create a new one with the same name, so they didn't get deleted. I'm just speculating here.

[awwRoar]

Same issue. On an Android tablet. I added multiple images on to a page like a moodboard and moved on to the next page for some drawing.

Pace of work - usual.

When I came back, the images were all corrupt. Aspect ratios maintained but a single image replaced a few of them and the rest are now transparent.

No idea what happened or how the issue can be reproduced :/