saber icon indicating copy to clipboard operation
saber copied to clipboard

Option to turn off stylus button undo

Open pjaml opened this issue 1 year ago • 5 comments

Before submitting an issue, please check the following

  • [X] I have searched for similar issues (both open and closed) and cannot find a duplicate
  • [X] I agree to follow the Code of Conduct

Motivation

Holding the stylus (S Pen) button and tapping the screen invokes undo. The problem is I frequently press this button accidentally, undoing whatever I'm in the process of writing. Also, sometimes when I hold the stylus button down intending to erase, it undoes instead because I haven't dragged the stylus or held it down on the screen long enough.

Solution

I'd like there to be an option in the settings to turn off this "Hold stylus button and tap screen to undo" feature.

Alternatives

No response

Saber version

v0.19.2 F-Droid (19020)

Device

  • Device: Samsung Galaxy Tab S6 Lite
  • OS: Android 13

Anything else?

Saber keeps getting better and better, thanks for making this app!

pjaml avatar Jan 29 '24 21:01 pjaml

Maybe related #1006

atahanacar avatar Jan 30 '24 01:01 atahanacar

Maybe related #1006

I've noticed that issue too, but I think I'd still want this feature even if it gets fixed.

pjaml avatar Jan 30 '24 19:01 pjaml

@adil192 I will implement this if we can agree on specifics such as where on the settings page it will go. I think creating a separate section called "Stylus" would be acceptable, in case new options regarding stylus usage (like assigning tools to physical buttons) are implemented.

atahanacar avatar Mar 26 '24 17:03 atahanacar

Is this particular to stylus? It seems simlar (related?) to the "undesirable undo with two fingers" bug https://github.com/saber-notes/saber/issues/643.

Polux49 avatar Apr 30 '24 15:04 Polux49

Is this particular to stylus?

Yes it is. The issue you mentioned is actually a bug caused (I think after a quick skim) by a feature that's supposed to prevent accidental strokes when zooming. This issue is a feature request that is asking to add an option to disable a feature.

atahanacar avatar May 03 '24 21:05 atahanacar

There is no such feature, just a bug causing an undo. Closing as duplicate of #1006

adil192 avatar Jun 17 '24 07:06 adil192