saber icon indicating copy to clipboard operation
saber copied to clipboard

Move selection to another page

Open QubaB opened this issue 2 years ago • 9 comments

Implemented moving selection across pages. Undo/redo works.

In Select added pageIndexStart holding original page of selection. In EditorHistory added pageIndexStart - important only for move In Editor is mainly change onDrawUpdate which should handle moving items to another page.

Closes #932

QubaB avatar Dec 31 '23 07:12 QubaB

Codecov Report

Attention: Patch coverage is 8.23529% with 78 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (64899f8) to head (3350fc4).

:exclamation: Current head 3350fc4 differs from pull request most recent head ce101ee

Please upload reports for the commit ce101ee to get more accurate results.

Files Patch % Lines
lib/pages/editor/editor.dart 6.09% 77 Missing :warning:
lib/data/tools/select.dart 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   35.95%   37.07%   +1.12%     
==========================================
  Files         115      110       -5     
  Lines        9076     8675     -401     
==========================================
- Hits         3263     3216      -47     
+ Misses       5813     5459     -354     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 31 '23 07:12 codecov[bot]

What is the status here? What is blocking this MR?

CommanderRedYT avatar Jun 19 '24 06:06 CommanderRedYT

I hope that from my side is all done.

QubaB avatar Jun 19 '24 07:06 QubaB

Thank you for coming back to this, I'm also patiently waiting for this to get resolved.

From what I understand, the status of this Pull Request is "This branch has conflicts that must be resolved". Maybe there are conflicting changes with the current state of the main branch?

jaklt avatar Jun 19 '24 07:06 jaklt

Thank you for coming back to this, I'm also patiently waiting for this to get resolved.

From what I understand, the status of this Pull Request is "This branch has conflicts that must be resolved". Maybe there are conflicting changes with the current state of the main branch?

Yes, but this conflict can resolve only person with write access to repository, and I have no write access.

QubaB avatar Jun 19 '24 08:06 QubaB

I tried to solve problem but one of the tests did not passed. @adil192, can you resolve it please. I have no idea how to improve my pull request more.

QubaB avatar Jun 19 '24 11:06 QubaB

@QubaB I am not sure about the rebase, there seems to be quite a huge amount of changes (many more files than before), I am not sure if this is intended.

CommanderRedYT avatar Jun 19 '24 11:06 CommanderRedYT

I merged current main to my branch to be able to handle problem with commit in editor.dart (editor.dart was improved since Dec 2023). I am not familiar too much with merging branches. I hope @adil192 can manage it somehow.

QubaB avatar Jun 19 '24 13:06 QubaB

Any updates on this?

IsotoxalDev avatar Jul 13 '24 17:07 IsotoxalDev