hassio-google-drive-backup
hassio-google-drive-backup copied to clipboard
upgrade (partial) backups are not ignored anymore
Since about the new year, my upgrade backups are not ignored anymore and are treated like full backups.
I was unable to reproduce this when testing locally. Could you download one of the mis-categorized backups, extract it, and get me the backup,json file inside it?
This was correctly identified: backup.json (I am pretty new and hadn't had the time to familiarise myself with HA, so I hope this is helpfull ^^ and thank you very much for creating and maintaining this addon)
so, then it's not me! that really happens! that make sense
so here are my backup.json files, they are ssh addon and nodered addon respectively, both from the community repo
at a quick glance the difference seems to be the empty addon array in the unrecognized bk.json
Thanks for providing those examples. I think the problem is that the addon only considers it an "upgrade" backup if it has exactly 1 folder or addon in the backup. From the looks of it, that backup has nothing in it. Are you sure anything is in the backup with not_rocignized_backup.json in it?
(Also sorry for taking a while to get back, life and stuff)
Are you sure anything is in the backup
yep, if i remember correctly it is a backup of nodered addon
Also sorry
no problem
Ok I suspect whats happening here is supervisor upgrade backups aren't getting ignored. They don't include any folders or addons. I can reproduce this by creating a partial backup that doesn't include any folders or addons, but does indicate the supervisor version being used. I believe thats how supervisor "backups" are indicated. I'll fix this in the next version.