Raphael Schweikert
Raphael Schweikert
Back when I wrote in, I wasn’t yet using PMD 7.1.0 but now I’ve upgraded and I’m seeing the issue sporadically still (alas, not reproducibly). I am using gradle with...
@adangel Ah yes, you’re right I did still use the old version. I had a manual reference to the dependency, so just changing the version in the quality plugin didn’t...
``` Execution failed for task ':core:pmdMain'. > net.sourceforge.pmd.util.ContextedAssertionError: This should be unreachable: Method 'public final net.sourceforge.pmd.lang.document.Chars net.sourceforge.pmd.lang.java.ast.AbstractLiteral.getLiteralText()' should be accessible, but: java.lang.IllegalAccessException: no such method: net.sourceforge.pmd.lang.java.ast.ASTNumericLiteral.getLiteralText()Chars/invokeVirtual Exception Context: [1:Rule applied...
Another one: ``` > net.sourceforge.pmd.util.ContextedAssertionError: This should be unreachable: Method 'public final net.sourceforge.pmd.lang.document.Chars net.sourceforge.pmd.lang.java.ast.AbstractLiteral.getLiteralText()' should be accessible, but: java.lang.IllegalAccessException: no such method: net.sourceforge.pmd.lang.java.ast.ASTStringLiteral.getLiteralText()Chars/invokeVirtual Exception Context: [1:Rule applied on node=!debug only!...
Can you rebase this against the current master and I will merge it.
@ziegenberg IMHO you could have put the deprecations into a single PR instead of doing a new PR for every single method. Thanks a lot for your contributions, though.
It seems @oliverklee and I disagree about what is an atomic change…
I guess a compromise would have been to make it a single PR but one commit for each change. That would have made them revertable without all the drawbacks.
IMHO named colors should be parsed into rgb colors with an additional flag. On output, these could be rendered to names again using a reverse-lookup table. Also, we should add...
> It was not possible to put the selectors in a comma-separated list, because each browser would barf upon encountering a rival's vendor prefix. Take care not to confuse syntactically-invalid...