Raphael Schweikert

Results 69 comments of Raphael Schweikert

Thanks @westonruter for investigating

Yes, BOM handling was part of the work on #116 and when we revisit that, we’ll surely handle the BOM gracefully. I think in general the BOM contains useful hints...

I’m not sure this is true. When the rule value is an identifier, it will be a string stored in `mValue`: ```css .test { white-space: nowrap; } ``` will parse...

AFAICT the type for `mValue` should be `Value|string`. IMHO we should also get rid of `null` and just use `""` for the default value.

@raxbg Maybe you’re parsing in lenient mode? `@supports` is currently unsupported so this issue is valid IMHO.

I agree with @raxbg. We throw errors when we can‘t make sense of the input (and we try to recover in lenient mode). But throwing errors when we can understand...

Thanks for your interest in the project. I have no qualms with making private methods protected. Send me a pull request and I’ll merge it. As for the streaming parser...

There are different definitions of what a streaming parser is but I was thinking of a stream that possibly may not yet be read till the very end. Such parsers...

It’s possible we falsely parse `or (transform-style:preserve-3d)` as a function but I’m not sure as I don’t know the code path used for `@supports`, will need to investigate.

@EvanHerman Hm, I agree it’s a bug but I don’t currently have any time to look into this myself. I’ll gladly accept PRs though…