sentelic
sentelic copied to clipboard
saaros
Build as a module
It would be great if this could be built as a module against existing kernel and replace the currently installed module.
Instructions/modifications to achieve this would be great.
Also, the asix patch can be removed since it's in mainline since rc7 - http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=e8303a3b2196272c3eb994d0fd1a189a958a2bdd
Once the driver has been submitted and accepted upstream the distro kernel maintainers should be willing to add the patch to their kernels even if it's not yet updated to the latest upstream version. I'm not going to create a Makefile for building standalone modules from my sentelic tree, as at least in Fedora the psmouse driver is not built as a module by default and you couldn't use the module with the stock kernel anyway. But I'll consider merging such a Makefile into my repo if you create one.
I've dropped the ASIX patch from my repo.
Thanks!
I found this https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/681904/comments/64
It works as it is given, but when I use the src files from this repo, I get this output.
DKMS make.log for psmouse-elantech-v6 for kernel 3.2.9-030209-generic (x86_64) Fri Mar 2 14:40:31 PST 2012 make: Entering directory `/usr/src/linux-headers-3.2.9-030209-generic' CC [M] /var/lib/dkms/psmouse/elantech-v6/build/src/psmouse-base.o /var/lib/dkms/psmouse/elantech-v6/build/src/psmouse-base.c:862:3: warning: initialization from incompatible pointer type [enabled by default] /var/lib/dkms/psmouse/elantech-v6/build/src/psmouse-base.c:862:3: warning: (near initialization for ‘psmouse_protocols[10].detect’) [enabled by default] CC [M] /var/lib/dkms/psmouse/elantech-v6/build/src/synaptics.o CC [M] /var/lib/dkms/psmouse/elantech-v6/build/src/alps.o CC [M] /var/lib/dkms/psmouse/elantech-v6/build/src/elantech.o CC [M] /var/lib/dkms/psmouse/elantech-v6/build/src/logips2pp.o CC [M] /var/lib/dkms/psmouse/elantech-v6/build/src/lifebook.o CC [M] /var/lib/dkms/psmouse/elantech-v6/build/src/sentelic.o /var/lib/dkms/psmouse/elantech-v6/build/src/sentelic.c: In function ‘fsp_init’: /var/lib/dkms/psmouse/elantech-v6/build/src/sentelic.c:978:2: error: implicit declaration of function ‘psmouse_info’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors
make[1]: *** [/var/lib/dkms/psmouse/elantech-v6/build/src/sentelic.o] Error 1 make: *** [psmouse.ko] Error 2 make: Leaving directory `/usr/src/linux-headers-3.2.9-030209-generic'
How is this patch going regarding upstream submitting and acceptance? Is there anything we can do to encourage it?
Thanks for your work.
Seems to be rolling on: https://github.com/saaros/sentelic/issues/3#issuecomment-4872812
Patching and building your own kernel isn't that difficult.
Supported in the Kernel since 3.4: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=2f7fa1be66dce77608330c5eb918d6360b5525f2
Unfortunately two finger scrolling doesn't work as well for me: https://bugzilla.kernel.org/show_bug.cgi?id=43591
In my case, kernel 3.4 and this patch does exactly the same. Two-finger scrolling is buggy, edge scrolling isn't working and cursor jumps on the edges (issue #6)
Also, don't forget the other kernel.org bug: https://bugzilla.kernel.org/show_bug.cgi?id=43197
Without this patch (on older kernels) double-finger scrolling didn't work, edge scrolling also didn't work, but cursor wasn't jumping.
What about with the current kernel without this patch? I have discovered that with the vanilla kernel the two fingered tap interferes with two finger scrolling. If I disable one the other works as expected.
After applying v3 patch (and modifying one line as said in later comment) from kernel bugzilla, the cursor doesn't jump, two-finger vertical scrolling partially works (it usually scrolls but when i put finger up, it returns to original position) and edge scrolling doesn't work. Tried changing hscroll attribute in /sys/devices/platform/i8042/serio2, but it didn't do anything.