dummy_thicc icon indicating copy to clipboard operation
dummy_thicc copied to clipboard

adds armv7 slice

Open dipidoo opened this issue 5 years ago • 1 comments

Test still pending, I saw my iPhone 5 somewhere a few weeks ago but now it decided to hide. I will update README once found and tested. In the meantime how do you feel about CMake? I can remove it if undesirable.

dipidoo avatar Sep 18 '20 07:09 dipidoo

Hi @dipidoo! Thanks for taking the time to contribute, interest in adding new slices is always welcomed (#2, #3 not being touched for a while notwithstanding: I’ll get around to those soon.

To my knowledge, iPhone 5 ships with the A6 “Swift” processor, the same as iPhone 5c which is one of the devices I happen to have. These actually support “arm7s” (a small extension of armv7), which is what we have right now in the tree: I know you’ve mentioned that you haven’t tried it yet, but I suspect if you tried to run a fat binary with your slice in it it would never get chosen on your phone. To truly test armv7 we’d need an iPhone 3GS, iPhone 4, or iPhone 4S as those ship with plain old armv7 processors. So until we find someone with that I think we’ll have to put this slice on pause :(

About CMake: I have no moral objection to it, other than it possibly being a bit of an overkill for something like this (perhaps I could write a shell script to aid testing, though). The problems I see arising is that it won’t actually be all that useful going forwards as we move towards the stranger architectures with more obscure toolchains where it’d be a task to even get a C compiler up for them, let alone figure out how to get that integrated with CMake either natively on that platform or via a cross-compiler on something newer. If you have thoughts, if be happy to hear them.

(Oh, and I fat-fingered the “close and comment” button, which is why the history if this is a bit disjoint. Sorry about that.)

saagarjha avatar Sep 20 '20 07:09 saagarjha