OpenAdBlock icon indicating copy to clipboard operation
OpenAdBlock copied to clipboard

Safari Content Blockers crash if the blocker list is too large

Open saagarjha opened this issue 9 years ago • 8 comments

Seems to be a bug in the content blocker loader. Anyone not experiencing this problem?

saagarjha avatar Sep 11 '15 00:09 saagarjha

I think this is the same issue being experienced by similar project https://github.com/rocketshipapps/adblockfast/issues/26

azinicus avatar Nov 18 '15 06:11 azinicus

Yes it looks like it. I'm not sure if it's a bug with the CSS or SFContentBlockerManager, since all I get is a crash log.

saagarjha avatar Nov 18 '15 06:11 saagarjha

Although it seems from my brief testing that the .json from this project actually blocks things whereas the AdblockFast one does not currently initiate by iOS (that one is much larger btw)

azinicus avatar Nov 18 '15 06:11 azinicus

This was the most complex one that seemed to work.

saagarjha avatar Nov 18 '15 06:11 saagarjha

Safari is meant to handle up to 50K rules, so your list is unlikely too big. In the case of Adblock Fast, I introduced a syntax error that Safari was failing silently on.

oldestlivingboy avatar Dec 02 '15 16:12 oldestlivingboy

That might be it. I'll have to look into it.

saagarjha avatar Dec 04 '15 06:12 saagarjha

Interested where the number 50K comes from

mcfedr avatar Sep 26 '16 08:09 mcfedr

I believe this number has been increased recently, actually. I'll look into it.

saagarjha avatar Sep 26 '16 15:09 saagarjha