daisyui icon indicating copy to clipboard operation
daisyui copied to clipboard

Feat/comment

Open imanmalekian31 opened this issue 3 years ago โ€ข 4 comments

New Comment component.

imanmalekian31 avatar Jul 15 '22 06:07 imanmalekian31

@imanmalekian31 @PadowYT2 what is the status on this?

taylorjdawson avatar Sep 28 '22 19:09 taylorjdawson

@taylorjdawson, @saadeghi should answer it :)

imanmalekian31 avatar Sep 29 '22 05:09 imanmalekian31

And I'm not a dev, just a user

PadowYT2 avatar Sep 30 '22 14:09 PadowYT2

It's on hold. We need to be careful.
I know it's exciting to get new components faster but if we don't consider all use cases for a component, we will have unnecessary breaking changes, forcing everyone to change their HTML, and that's not good at all.
I hope you understand and give it time because reviewing PRs like this is not just reviewing the code. It's about design and testing it will all possible common use cases a designer may think of for that specific component.

saadeghi avatar Oct 02 '22 19:10 saadeghi

Moving forward with version 3.0 I have no plans for adding a comment class for now. There are many designs that can be implemented and we need to be flexible with that however the main difference between different designs of a comment box is mostly the grid/flex layout which is already easy to make using Tailwind utility classes.

Thanks for the PR

saadeghi avatar Jun 01 '23 02:06 saadeghi