daisyui icon indicating copy to clipboard operation
daisyui copied to clipboard

bug: `mb-*` override by `timeline-compact` when used with `timeline-start` but not `timeline-end`

Open HarryHung opened this issue 1 year ago โ€ข 3 comments

What version of daisyUI are you using?

v4.12.10

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/90vptzttvW

Describe your issue

I notice that when a timeline is built with timeline-compact class, mb-10 or any bottom margin class is overriden in items with timeline-start class, but not those with timeline-end class, making the separation between items inconsistency.

This behaviour is observable in DaisyUI own example when it switch to a compact timeline: https://daisyui.com/components/timeline/#timeline-with-icon-snapped-to-the-start

My own React module built based on the example code also have the same issue, it could be workaround by marking mb-* class as important (e.g. !mb-10)

HarryHung avatar Oct 03 '24 16:10 HarryHung

Thank you @HarryHung for reporting issues. It helps daisyUI a lot ๐Ÿ’š
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

github-actions[bot] avatar Oct 03 '24 16:10 github-actions[bot]

Will be fixed in daisyUI 5.
Until then you can use pb-10 instead. (or !mb-10)

saadeghi avatar Oct 09 '24 11:10 saadeghi

Thank you for the info and your effort. I am looking forward to v5.

HarryHung avatar Oct 09 '24 13:10 HarryHung