daisyui icon indicating copy to clipboard operation
daisyui copied to clipboard

bug: btn btn-link btn-disabled looks like button but not link

Open bogdan opened this issue 1 year ago โ€ข 3 comments

What version of daisyUI are you using?

No response

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/8cJA9JDvCP

Describe your issue

I believe that when btn btn-link btn-disabled are used together, the result should look like Link but not a button. While, link-disabled is not currently defined, I believe the fact that these 3 classes can be used together requires to define a style for disabled link. In practice the disabled link can be used like this:

<div class="tooltip " data-tip="Profile is not yet published" >
  <a href="#" class="link link-disabled">View Public Profile</a>
</div>

bogdan avatar Sep 22 '24 10:09 bogdan

Thank you @bogdan for reporting issues. It helps daisyUI a lot ๐Ÿ’š
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

github-actions[bot] avatar Sep 22 '24 10:09 github-actions[bot]

How should it look like?

saadeghi avatar Sep 22 '24 10:09 saadeghi

I believe like so: https://play.tailwindcss.com/00Fv24VDxV

image

bogdan avatar Sep 23 '24 08:09 bogdan

can you assign me this issue

nilaygit-10721 avatar Nov 05 '24 13:11 nilaygit-10721

Thanks @nilaygit-10721
All issues with v5 tag are already fixed in daisyUI 5 (alpha) or are in progress.
I can't change this style in daisyUI 4 because this visual change is a breaking change and it will effect all the existing apps who are relying on the previous behavior.

daisyUI 5 will be released soon after Tailwind CSS 4

saadeghi avatar Nov 05 '24 14:11 saadeghi

So is btn-ghost: https://github.com/saadeghi/daisyui/issues/3285

tats-u avatar Nov 21 '24 23:11 tats-u