daisyui icon indicating copy to clipboard operation
daisyui copied to clipboard

bug: btn doesn't accept `--fallback` tokens as first option.

Open icukovic opened this issue 1 year ago โ€ข 3 comments

What version of daisyUI are you using?

v4.10.1

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/XuToYOqkWo

Describe your issue

While playing around with daisyUI I've noticed that the daisyUI Button is not taking --fallback-p CSS token as the the first var() option for background color, due to implementation with token called --btn-color and it always expects --falback-p or --p to be in oklch format

daisyUI src/component/styled/button.css as of today for browsers that support oklch generates:

image

while src/components/styled/badge.css for comparison always accepts --fallback tokens as first and they can be in any type value. image

icukovic avatar Apr 11 '24 10:04 icukovic

Thank you @icukovic for reporting issues. It helps daisyUI a lot ๐Ÿ’š
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

github-actions[bot] avatar Apr 11 '24 10:04 github-actions[bot]

Also I understand that this --btn-color was created to simplify button states recoloring with color-mix function.

icukovic avatar Apr 11 '24 10:04 icukovic

I also noticed this when trying to use daisyui custom themes in an email client, which doesn't support oklch

khuezy avatar Jul 25 '24 22:07 khuezy