daisyui icon indicating copy to clipboard operation
daisyui copied to clipboard

bug: v3 Join Buttons overlap when clicked

Open TomatoGuy0502 opened this issue 2 years ago โ€ข 1 comments

What version of daisyUI are you using?

v3.0.3

Describe your issue

When the button in Join is clicked, the button in focus will overlap the other button by 1px.

https://github.com/saadeghi/daisyui/assets/49487217/4e930055-2ce1-4fa0-a81a-2e8603b43e50

What browsers are you seeing the problem on?

Edge

Reproduction URL (optional)

https://play.tailwindcss.com/6CDE3fLoa8

TomatoGuy0502 avatar Jun 06 '23 12:06 TomatoGuy0502

Join overlaps items on each other by one pixel. Because when we user outline buttons or bordered inputs next to each other we only need 1px border between them.

It doesn't remove the border (because in that case which border should be removed and why?)
Also when normally buttons are next to each other and we start navigating them using tab key, they get an outline but each item's outline will go under the next item. To avoid this we bring the focused item to the front so whenever you focus an item it covers the other item.

This may not be perfect but if anyone can suggest a better behavior, I will implement that.

saadeghi avatar Jun 06 '23 23:06 saadeghi