coresoftware

coresoftware copied to clipboard

sPHENIX-Collaboration

Reame
Issues

refactor: bco counting code

Open osbornjd opened this issue 1 month ago • 3 comments

This PR refactors the bcolumi code added by Zhiwan into the main pool input objects so that maintenance long term is easier. Currently the v2 objects that were added are standalone, and thus, don't benefit from any of the changes in the last months. This should not change any default performance/functionality.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
[ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
[x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Nov 14 '25 19:11 osbornjd

Let's wait until next week to merge this in case there are unforeseen consequences...

Nov 14 '25 19:11 osbornjd

Build & test report

Report for commit 45a96b5c0b1358f0812a401182b9b18db0f09c57:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-intt : combined Chi2/nDoF = 0.000381874 / 18, and combined p-Value = 1
  - :bar_chart: QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - :bar_chart: QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - :bar_chart: QA-siliconseeds : combined Chi2/nDoF = 0.0522585 / 20, and combined p-Value = 1
  - :bar_chart: QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - :bar_chart: QA-tpcseeds : combined Chi2/nDoF = 0.0522584 / 28, and combined p-Value = 1
  - :bar_chart: QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Nov 15 '25 02:11 sphenix-jenkins-ci[bot]

@pinkenburg this shouldn't break anything as it is just adding additional functionality - but a second set of eyes wouldn't hurt...

Nov 19 '25 14:11 osbornjd