coresoftware

coresoftware copied to clipboard

sPHENIX-Collaboration

Reame
Issues

CaloCDB: Add ZS Cross-Calibration

Open Steepspace opened this issue 2 months ago • 1 comments

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
[ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
[x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

The GenStatus module is updated to include and process Zero Suppression (ZS) Cross-Calibration histograms. Crucially, it now checks if histograms contain data before generating CDB payloads to prevent writing empty trees.

Safety/Integrity Check (Major Change): Added a check using ->GetEntries() to all histogram-to-CDB-Tree operations in the analyze method. This ensures a CDB payload file is only created if the corresponding histogram contains data.
New Histograms: Added TProfile2D members for CEMC, HCALIN, and HCALOUT ZS cross-calibration: h_CaloFittingQA_*_ZScrosscalib.
Read/Merge: Modified readHists to search for and merge these new ZS cross-calibration histograms from input files.
Payload Generation: Updated analyze to create new CDB payloads for *_ZSCrossCalib for all three calorimeters (CEMC, HCALIN, HCALOUT) using the field name "ratio".
File List: The readHists method now creates a file list (m_CaloValid_list) containing only files with "HIST_CALOQA", and this list is used by emcNoisyTowerFinder in process.
CDB Name List: Updated m_cdbName to include the three new ZS cross-calibration payload names: CEMC_ZSCrossCalib, HCALIN_ZSCrossCalib, and HCALOUT_ZSCrossCalib.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

https://github.com/sPHENIX-Collaboration/macros/pull/1217

Oct 15 '25 04:10 Steepspace

Build & test report

Report for commit a9490da5de3015de03ce219b7ec8d24b0fb985f3:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 1.09892e-11 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 73.0632 / 56, and combined p-Value = 0.0624853
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 34.23 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 6.67132 / 50, and combined p-Value = 1
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0124 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - :bar_chart: QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - :bar_chart: QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - :bar_chart: QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - :bar_chart: QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
  - :bar_chart: QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Oct 15 '25 10:10 sphenix-jenkins-ci[bot]