Various improvements to PHCASeeding

[david-stewart]

• Functionally fixes the PHCASeeding->SetSplitSeeds(false); to work as expected.
• Removes the separate mapTrkrDefs::cluskey,vector3 to just making a single vector list of the {cluskey,vector} data with pointers in the links. This is for efficiency, and works nicely. This also saves recalculating phi many times.
• When adding clusters, don't continually recalculate phi, dphi, R, dR, dzdR, d2phidr2, but only as needed. Again this is for efficiency.

Still needed:

• The cluster still makes all combinations of all triplets to start tracks. This should be either ignored (start further down the chain) or squashed into average clusters.
• Have the seeds start in the middle, grow inward, then outward

Given that the default Fun4All macro splits the tracks, this shouldn't change the QA. I'll wait to see them before asking for the PR merge.

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
• [ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• [x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit a6cabab5cfe6df22bf44f5ae32e64e972a6ce51c:

• builds and tests overall are FAILURE.

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit 4f83926f481096fe93565c51a73aaf25c593670a:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is FAILURE, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / scan is FAILURE, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[david-stewart]

Hi @pinkenburg / @osbornjd -- I made this PR on a sphnx interactive node and it ran ok. It is failing the alma9 node builds. Should I log onto an alma9 node to check this out and resubmit?

[osbornjd]

Looks like the newer version of g++ picks up a possible error https://web.sdcc.bnl.gov/jenkins-sphenix/job/sPHENIX/job/Build-Master-gcc14/401/artifact/build/new/rebuild.log/view/

I would login to an alma9 node, try to compile there, and debug and push a commit

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit d146442f6a0ccbd0debbef4cc7e638db807cdd9c:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / scan is FAILURE, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit 82580280f7cd07315573afd06a9cd5bdbe5b4fb1:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 3.7388 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 36.6822 / 72, and combined p-Value = 0.999828
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 2.32973e-05 / 42, and combined p-Value = 1
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.3602 / 42, and combined p-Value = 0.986551
  • Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
  • Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
  • Tracking QA for Pythia D0-jet: build is FAILURE, :bar_chart: trends
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit 57d30b6b31bfaeb262ba758715d246bdc3e2b198:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 48.1413 / 72, and combined p-Value = 0.986312
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 10.261 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
  • Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
  • Tracking QA for Pythia D0-jet: build is FAILURE, :bar_chart: trends
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is FAILURE, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is FAILURE, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit c06185da5350dbb524a7139490aa3261b0b33f40:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 48.1413 / 72, and combined p-Value = 0.986312
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 10.261 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
  • Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
  • Tracking QA for Pythia D0-jet: build is FAILURE, :bar_chart: trends
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is FAILURE, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit a1cd61cc8792e3ba10f3dcd1cc882496bc9432b9:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 17.1592 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 607.453 / 56, and combined p-Value = 1.32913e-93
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 86.4671 / 112, and combined p-Value = 0.964907
  • Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 3.12328 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 146.079 / 50, and combined p-Value = 2.4041e-11
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 44.1084 / 112, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[osbornjd]

This improves the efficiency in the simulation pretty substantially, do you have some QA checks on the data too?

[david-stewart]

This improves the efficiency in the simulation pretty substantially, do you have some QA checks on the data too?

Hey @osbornjd, I looked at the Jupyter QA plots earlier, and I do not understand why the efficiency is so much better. I was hoping that it was because of other changes in the process/distortion corrections that are happening concurrently. I had better check in data and see what happens, just to make sure it's not something that would blow up the combinatorics dramatically.

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit 4691a1240e52077096cfd6f8328cc3dccebc7036:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.0380467 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 480.566 / 56, and combined p-Value = 8.72065e-69
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0254 / 112, and combined p-Value = 1
  • Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.0207139 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 1.48849 / 50, and combined p-Value = 1
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is UNSTABLE, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[david-stewart]

OK, the results on spot checking with actual data are identical. There is a complaint from Valgrind, but there isn't any dynamically allocated memory -- they are all allocated into std::vector. What is manual are pointers to that vector, but the memory can't actually be leaked, as both the vector of data, and the vector of pointers, are managed automatically.

[david-stewart]

Hi @osbornjd -- I believe that this is ready to merge. In other consideration, there is also @petermic 's PR, which wouldrequire some synthesis to take both of them.

[osbornjd]

How does this mesh with Michael's PR? Maybe we should come up with a plan for how to merge both and/or understand how they help/hurt each other

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit 6c03611228892b883eccf200a1316bd53f0c38c6:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 26.1477 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 39.8136 / 72, and combined p-Value = 0.999258
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 26.3832 / 42, and combined p-Value = 0.971427
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 10.0335 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
  • Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
  • Tracking QA for Pythia D0-jet: build is FAILURE, :bar_chart: trends
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is FAILURE, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is UNSTABLE, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit c61e573b215453df2ffbb79fa292b3cd210c489b:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 26.1477 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 39.8136 / 72, and combined p-Value = 0.999258
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 26.3832 / 42, and combined p-Value = 0.971427
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 10.0335 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
  • Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
  • Tracking QA for Pythia D0-jet: build is FAILURE, :bar_chart: trends
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is FAILURE, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is FAILURE, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit e5d2f20c7306cba9f1caf8a9fc6105377124a260:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 22.6503 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 27.2034 / 42, and combined p-Value = 0.962535
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
  • Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
  • Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.0287419 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 1.19842 / 50, and combined p-Value = 1
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit c89d662c5d2edd032cf1392c4e85666b98fef645:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 22.6503 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 27.2034 / 42, and combined p-Value = 0.962535
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
  • Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
  • Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.00628118 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 1.19842 / 50, and combined p-Value = 1
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit e5264807f5b73244ecc6495f0d9562db5b12fabd:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.00418421 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 459.956 / 56, and combined p-Value = 8.02296e-65
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0105 / 112, and combined p-Value = 1
  • Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 3.07477e-05 / 56, and combined p-Value = 1
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 1.22107 / 50, and combined p-Value = 1
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[david-stewart]

OK @petermic -- there are still some algorithmic choices to made regarding removing duplicate seeds, but I think that this successfully merges your PR code. So, if all is good, I think it is all ready to merge.

[david-stewart]

Hi @osbornjd -- I think that this is ready to merge. There are still algorithmic choices to made, but it is essentially a merge of @petermic 's PR and this one

[osbornjd]

I may have missed something, but I thought @petermic still wanted to do some development on his PR? Because it halved the efficiency in AuAu data

[david-stewart]

ah, ok, that may be true. I haven't tested with the data outside of Jenkins. I'll talk with @petermic and maybe just merge this one with his and then the single PR can go in eventually.

[osbornjd]

Have you also run tests with this one on some data too?

[david-stewart]

At least not after I merge in Michael's code with it