coresoftware icon indicating copy to clipboard operation
coresoftware copied to clipboard

Adding the photon kinematics for the EMCal clusters QA type plots

Open aahanab opened this issue 1 year ago • 1 comments

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
  • [ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • [x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Adding the photon kinematics plots (eta, phi, energy and chi squared) for the EMCal clusters. comment: <> ( What does this PR do? Linking to talk in software meeting encouraged )

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

aahanab avatar Oct 08 '24 14:10 aahanab

Build & test report

Report for commit 43fe149177589c3fb82a28e2ced30407ef85061b: Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Oct 08 '24 19:10 sphenix-jenkins-ci[bot]

Build & test report

Report for commit 3646d30039ff4d912afcfb7412b59222afc27d9a: Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Oct 15 '24 04:10 sphenix-jenkins-ci[bot]

Build & test report

Report for commit 36228822f427411b894cc2d48fef1c9b29ceee6b: Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Oct 29 '24 18:10 sphenix-jenkins-ci[bot]

Build & test report

Report for commit 0dbc266a27b7e64074505a21b5ac52f0cc3ae997: Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Nov 08 '24 20:11 sphenix-jenkins-ci[bot]

Build & test report

Report for commit 4a11793dcfe19ef80d6a217922717b8a5ae5b338: Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Nov 14 '24 19:11 sphenix-jenkins-ci[bot]

Build & test report

Report for commit d5417f0c32a48c019925440a71c456cb80ed1049: Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Feb 27 '25 23:02 sphenix-jenkins-ci[bot]

Build & test report

Report for commit fcc425ff52d03809cf31af0b8e7de5e8f0b52eb5: Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Feb 28 '25 07:02 sphenix-jenkins-ci[bot]

Hmmm... Interesting.... 🤔

I just double-checked: this branch does compile on the Alma9 nodes, and the new module runs in a test F4A macro...

ruse-traveler avatar Mar 07 '25 20:03 ruse-traveler

Please do not use github to merge your PR with the master, this just triggers a jenkins run and klogs up our system. Merge/rebase the master in your local fork - fix the problems and then push the PR when it's ready

pinkenburg avatar Mar 18 '25 15:03 pinkenburg

I could be misremembering, but I thought we discussed this last week: the previous Jenkins report indicated nothing wrong with the module here, I've confirmed that it compiles and runs natively under Alma9, and running cpp-check locally doesn't return any issues. And it was speculated that this could be due to Jenkins being interrupted (this could be the point I'm misremembered)...

Is there a way to run Jenkins that doesn't klog our system? For example, would an empty commit be better?

ruse-traveler avatar Mar 18 '25 16:03 ruse-traveler

I could be misremembering, but I thought we discussed this last week: the previous Jenkins report indicated nothing wrong with the module here, I've confirmed that it compiles and runs natively under Alma9, and running cpp-check locally doesn't return any issues. And it was speculated that this could be due to Jenkins being interrupted (this could be the point I'm misremembered)...

Is there a way to run Jenkins that doesn't klog our system? For example, would an empty commit be better?

that is a valid use, it is a way to trigger a jenkins run just like an empty commit. Sorry about the noise

pinkenburg avatar Mar 18 '25 16:03 pinkenburg

that is a valid use, it is a way to trigger a jenkins run just like an empty commit. Sorry about the noise

Gotcha! No worries! I want to make sure I'm not accidentally ddosing Jenkins 😅

ruse-traveler avatar Mar 18 '25 16:03 ruse-traveler

Build & test report

Report for commit 7f90e7a69c8cd31a4e3237fe17394d9c006e5a06: Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration sPHENIX             jenkins.io

sphenix-jenkins-ci[bot] avatar Mar 19 '25 00:03 sphenix-jenkins-ci[bot]