fix: Silicon seeding takes best INTT cluster in layer pair
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
- [ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
- [x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)
What kind of change does this PR introduce? (Bug fix, feature, ...)
This updates the silicon seeding to take the best cluster in an INTT layer pair instead of in each INTT layer individually, as discussed in the tracking meeting this morning
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Build & test report
Report for commit 35e0479a7f95237c8dc4a20e0fb21308e3c9dbc1:

builds and tests overall are SUCCESS.
Build with configuration of
gcc-12.1.0/clangis SUCCESS, :bar_chart:clang report (full)/(new), build logBuild with configuration of
gcc-12.1.0/newis SUCCESS, :bar_chart:Compiler report (full)/(new), build logGenerating DST and readback: build is SUCCESS
Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 1094.98 / 56, and combined p-Value = 1.41232e-192
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 438.997 / 112, and combined p-Value = 2.96763e-40
Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 212.314 / 50, and combined p-Value = 6.86106e-22
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 100.149 / 112, and combined p-Value = 0.781314
system
gcc-12.1.0, buildnew: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: run the overlap check for sPHENIX macro: build is SUCCESS, outputsystem
gcc-12.1.0, buildnew: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of
gcc-12.1.0/scanis SUCCESS, :bar_chart:scan-build report (full)/(new), build logclang-tidyis SUCCESS, :bar_chart:clang-tidyreport (full)/(new)cpp-checkis SUCCESS, :bar_chart:cppcheckreport (full)/(new)
Automatically generated by sPHENIX Jenkins continuous integration

Somehow this kills our efficiency. Needs more debugging apparently
Build & test report
Report for commit 1e5661aa0e3dc3d0eb711fd4423be4a2e3e8949b:

builds and tests overall are SUCCESS.
Build with configuration of
gcc-12.1.0/clangis SUCCESS, :bar_chart:clang report (full)/(new), build logBuild with configuration of
gcc-12.1.0/newis SUCCESS, :bar_chart:Compiler report (full)/(new), build logGenerating DST and readback: build is SUCCESS
Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 1094.98 / 56, and combined p-Value = 1.41232e-192
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 438.997 / 112, and combined p-Value = 2.96763e-40
Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 212.314 / 50, and combined p-Value = 6.86106e-22
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 100.659 / 112, and combined p-Value = 0.770349
system
gcc-12.1.0, buildnew: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: run the overlap check for sPHENIX macro: build is SUCCESS, outputsystem
gcc-12.1.0, buildnew: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of
gcc-12.1.0/scanis SUCCESS, :bar_chart:scan-build report (full)/(new), build logclang-tidyis SUCCESS, :bar_chart:clang-tidyreport (full)/(new)cpp-checkis SUCCESS, :bar_chart:cppcheckreport (full)/(new)
Automatically generated by sPHENIX Jenkins continuous integration

Build & test report
Report for commit 56d0d7249123aabb8eb0d01c94eefa12764ba576:

builds and tests overall are FAILURE.
Build with configuration of
gcc-12.1.0/clangis FAILURE, :bar_chart:clang report (full)/(new), build logBuild with configuration of
gcc-12.1.0/newis SUCCESS, :bar_chart:Compiler report (full)/(new), build logGenerating DST and readback: build is SUCCESS
Calorimeter QA: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
- :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
- :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
- :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 1094.84 / 56, and combined p-Value = 1.50801e-192
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 438.733 / 112, and combined p-Value = 3.2769e-40
Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
- :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
- :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
- :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
- :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
- :bar_chart: QA-tracking : combined Chi2/nDoF = 212.314 / 50, and combined p-Value = 6.86106e-22
- :bar_chart: QA-vertexing : combined Chi2/nDoF = 101.637 / 112, and combined p-Value = 0.748587
system
gcc-12.1.0, buildnew: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:system
gcc-12.1.0, buildnew: run the overlap check for sPHENIX macro: build is SUCCESS, outputsystem
gcc-12.1.0, buildnew: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of
gcc-12.1.0/scanis FAILURE, :bar_chart:scan-build report (full)/(new), build logclang-tidyis SUCCESS, :bar_chart:clang-tidyreport (full)/(new)cpp-checkis SUCCESS, :bar_chart:cppcheckreport (full)/(new)
Automatically generated by sPHENIX Jenkins continuous integration
