coresoftware Update PHGhostRejection:

Fix error in "is same track": it now compares clusters correctly
Fix error in comparing the delta_phi between tracks -- take into account periodic boundary
Change logic: for is-same track backs on shared clusters, the number of shared clusters must be simply more than 1/2 the number of clusters in the shorter track
Add default minimum track parameters (week out tracks, even if not otherwise duplicate/"ghost" tracks):
- minimum pT of 0.2 GeV/c
- minimum number of clusters of 6 - must have clusters crossing at least one sector boundary (i.e. crossing layer 22-23 or 39-40)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
[ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
[x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Jun 21 '24 06:06 david-stewart

Build & test report

Report for commit 048361a502aed04ea614bd83ae94ecddd3999012:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
- Tracking QA for Pythia D0-jet: build is FAILURE, :bar_chart: trends
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Jun 21 '24 11:06 sphenix-jenkins-ci[bot]

Looking at the code it isn't clear to me why this causes a seg fault in the low occupancy QA. I would suggest just checking out the branch yourself locally and running gdb on it with your local build

Jun 21 '24 13:06 osbornjd

ok. There are a few more things to do. I realized that it isn't hard to avoid publishing all the rejected tracks, so things will shake up a little first.

Jun 21 '24 13:06 david-stewart

Build & test report

Report for commit 6f101a3499ede2881f5a565f5af4ec1b41750743:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 1065.05 / 56, and combined p-Value = 2.10915e-186
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 440.267 / 56, and combined p-Value = 4.66975e-61
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 237.047 / 112, and combined p-Value = 5.5821e-11
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 578.629 / 56, and combined p-Value = 6.52585e-88
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 451.135 / 50, and combined p-Value = 5.9139e-66
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 84.2745 / 112, and combined p-Value = 0.976514
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is FAILURE, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Jun 21 '24 19:06 sphenix-jenkins-ci[bot]

Build & test report

Report for commit 088aa07e9f7a10d3d5845c75812944e018249d0b:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.183729 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 361.12 / 56, and combined p-Value = 3.51175e-46
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 303.359 / 112, and combined p-Value = 1.46824e-19
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.0273701 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 259.68 / 50, and combined p-Value = 4.24692e-30
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 56.9128 / 112, and combined p-Value = 0.999997
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Jun 22 '24 04:06 sphenix-jenkins-ci[bot]

OK, fixed the leak -- error in the looping variable when refactoring the code. The cuts remove quite a few tracks. For one random example: 36 total seeds: 13 rejected for pT < 200 MeV (10 of which < 100 MeV, one as low at 9 MeV) 1 more rejected for only having clustering in the middle layer (23-39) 6 more tracks removed because they were ghosts. In this case, every ghost had exactly the same clusters. (Looking over many runs, it is actually a smallish portion that deviate, and then only by a cluster or two). Specifically:

Found match for tracks 0 and 21 and 31 and 35
Found match for tracks 1 and 12
Found match for tracks 2 and 16 and 23

So a total of 14 tracks out of the 36 tracks reconstructed were pushed to the output TrackSeedContainer. This update doesn't tracks that are rejected to the container. (So, the track number outgoing isn't the same as the track number of the seed incoming, but I don't think that makes any different in our code). This is a change, as the old code number published every seed going in to the PHSimpleKFProp to the outgoing track container by the same track id index, even if some were deleted and only point to a nullptr.

I am curious was Marzia's 30000 track event would result in. It would also be better perhaps to not reconstruct each track 4 times in the Kalman filter. Maybe it would be better to add some logic that if a seed's clusters have already been reconstructed in another track, then to not reconstruct that seed. (For instance, the 0-21-31-35 track was reconstructed 4 times from four different seeds).

Jun 22 '24 06:06 david-stewart

This change really hurts the efficiency at low pT, presumably because we are rejecting real tracks in addition to all of the ghost tracks that it removes. Have you studied why these also get rejected?

Jun 22 '24 11:06 osbornjd

Hmmm. The cuts are these:

all tracks < 200 MeV
all tracks with < 6 clusters
all tracks with clusters which don't span a radial sector boundary
the lower chi2 out of each pair of tracks matching in phi/eta/x/y/z if one of the pair has at least 50% matching clusters

None of those should hurt efficiency particularly badly. The removing of ghosts is important, but that was already happening (although not after the first three cuts above)

Jun 22 '24 12:06 david-stewart

The <200 MeV cut might hurt efficiency quite a bit, if lots of higher-momentum seeds are erroneously being assigned much lower momenta due to spurious clusters being added to them (which usually drastically increase the average curvature). A plot of pt vs. gpt would probably work to reveal this.

Jun 27 '24 18:06 petermic

Build & test report

Report for commit a1005fc4f9dd69b07e30dd0ff6c58713d7af5768:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 45.6147 / 72, and combined p-Value = 0.993571
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.6126 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.9499 / 42, and combined p-Value = 0.937089
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 63.1178 / 42, and combined p-Value = 0.0191034
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.0621178 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 337.54 / 56, and combined p-Value = 7.57272e-42
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 241.795 / 112, and combined p-Value = 1.52247e-11
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.00397592 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 277.676 / 50, and combined p-Value = 2.58537e-33
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 59.0518 / 112, and combined p-Value = 0.999991
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Aug 02 '24 03:08 sphenix-jenkins-ci[bot]

The efficiency curves in the QA Juypter notebook haven't changed. I have run individual tests where I didn't think that I saw this behavior. I will get a good comparison test with slightly lower statistics nail down the inconsistency.

Aug 02 '24 11:08 david-stewart

Build & test report

Report for commit 2c168ea4a9de36015cab916e96f71eb25bea21c8:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 45.6147 / 72, and combined p-Value = 0.993571
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.6126 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.9499 / 42, and combined p-Value = 0.937089
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 63.1178 / 42, and combined p-Value = 0.0191034
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = 0.452105 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = 0.34184 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = 0.193942 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 1.02322 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 296.059 / 56, and combined p-Value = 2.29489e-34
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 32.9507 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 181.136 / 50, and combined p-Value = 9.39713e-17
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Aug 03 '24 02:08 sphenix-jenkins-ci[bot]

Build & test report

Report for commit b19f411135d45b6c96e1ee554811788334955054:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 45.6147 / 72, and combined p-Value = 0.993571
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.6126 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.9499 / 42, and combined p-Value = 0.937089
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 63.1178 / 42, and combined p-Value = 0.0191034
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 4.11074 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 645.828 / 56, and combined p-Value = 3.20887e-101
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0426 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.154116 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 149.037 / 50, and combined p-Value = 8.78255e-12
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Aug 05 '24 20:08 sphenix-jenkins-ci[bot]

Now that Michael's changes are in, we should probably be able to push this after we see if it works. There was a clang complaint in that a line of code float dphi = fabs(...); demoted a double to float. I have modified the line and pushed so that we can get the new Jenkin's report. If all is well with that, I recommend that we merge it.

Aug 20 '24 15:08 david-stewart

Build & test report

Report for commit 396e4bb370578e5003f54d38b8de99da5c093759:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 0.881906 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 493.55 / 56, and combined p-Value = 2.70516e-71
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0513 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 1.727e-06 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 48.6292 / 50, and combined p-Value = 0.52849
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0001 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Aug 20 '24 19:08 sphenix-jenkins-ci[bot]

Build & test report

Report for commit 55137d71be386fda9a308451f24c26dda3aff2ab:

builds and tests overall are SUCCESS.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 34.4216 / 72, and combined p-Value = 0.999949
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 31.4242 / 72, and combined p-Value = 0.999992
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 3.10515 / 42, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 13.6147 / 42, and combined p-Value = 0.99999
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 1.00896 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 493.55 / 56, and combined p-Value = 2.70516e-71
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0513 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 7.48976e-07 / 56, and combined p-Value = 1
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 48.6292 / 50, and combined p-Value = 0.52849
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 30.0001 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Aug 23 '24 04:08 sphenix-jenkins-ci[bot]

This kills the efficiency at low pT again - did that fix get removed inadvertently?

Aug 23 '24 12:08 osbornjd

Build & test report

Report for commit fa763a071a03032fc6688a47c7c0c05718fa985c:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is FAILURE, :bar_chart: trends
- Tracking QA with Distortions: build is FAILURE, :bar_chart: trends
- Tracking QA at low occupancy: build is FAILURE, :bar_chart: trends
- Tracking QA for Pythia D0-jet: build is FAILURE, :bar_chart: trends
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is FAILURE, output
- system gcc-12.1.0, build new: Valgrind test: build is FAILURE, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Aug 23 '24 19:08 sphenix-jenkins-ci[bot]

I'm not sure at all what I did to upset everything; but obviously my trying to something cut with git had external consequences. I'll push a branch backup_ghost that should be fine. Let's wait and see.

Aug 23 '24 22:08 david-stewart