binary_bakery icon indicating copy to clipboard operation
binary_bakery copied to clipboard

Published 20 hours ago • verified publisher icon s9w

(QA) fix PVS reports

Open GerHobbelt opened this issue 3 years ago • 1 comments

as reported by PVS Studio (a static code analyzer tool I use for some other projects too):

  • V801 Decreased performance. It is better to redefine the third function argument as a reference. Consider replacing 'const .. uncompressed_size' with 'const .. &uncompressed_size'. content_meta.cpp 62
  • V801 Decreased performance. It is better to redefine the fourth function argument as a reference. Consider replacing 'const .. compressed_size' with 'const .. &compressed_size'. content_meta.cpp 63

GerHobbelt avatar Oct 20 '21 19:10 GerHobbelt

Hi! Thanks for your interest in this, and sending this through PVS. So the type of the parameter in question only has an int member and is hence the same size. Last time I checked, common wisdom was to not pass such parameters as reference. Did that change? Any insights on that?

s9w avatar Oct 21 '21 10:10 s9w