Abdelhafidh Belalia comments

Results 422 comments of


                                            Abdelhafidh Belalia

Add automated tests for `getGroupChatName()`

No regression test needed. We only adds tests.

Enable creating a group chat with one other participant

## Reviewer Checklist - [X] I have verified the author checklist is complete (all boxes are checked off). - [X] I verified the correct issue is linked in the `###...

fix: Web - Persistence of Tax Selection When Navigating to Other Pages and Returning

Looks good to me. Working on the checklist... While we are fixing these bugs please merge main and fix the same for `ReportParticipantsPage` (it has same logic as `WorkspaceMembersPage`)

fix: Web - Persistence of Tax Selection When Navigating to Other Pages and Returning

## Reviewer Checklist - [X] I have verified the author checklist is complete (all boxes are checked off). - [X] I verified the correct issue is linked in the `###...

fix: Web - Persistence of Tax Selection When Navigating to Other Pages and Returning

Let me know once this is resolved https://github.com/Expensify/App/pull/40136#issuecomment-2053590276

fix: Web - Persistence of Tax Selection When Navigating to Other Pages and Returning

Thank you!

fix: Web - Persistence of Tax Selection When Navigating to Other Pages and Returning

@hayata-suenaga The clean up function in `useFocusEffect` will get executed whenever the dependencies change (even if the page is focused). In our case this shouldn't case a problem but it's...

[$500] Do not allow emojis to be formatted (ie italics)

@tienifr Your approach looks solid however the regex is not correct as it will only match one emoji, try sending `hi 😁 there 😁`, it will wrap the first emoji...

[$500] Do not allow emojis to be formatted (ie italics)

@tienifr - You can use the same regex as provided, there is no need to create a capturing group that captures the whole match (unnecessary doubling memory usage) - If...

[$500] Do not allow emojis to be formatted (ie italics)

@tienifr While seaching I found this image. The middle emoji is in bold but it's hard to notice also it may depend on the font. Adding `fontWeight: 'normal'` is more...