Tap-Titans-2-Progress-Bot icon indicating copy to clipboard operation
Tap-Titans-2-Progress-Bot copied to clipboard

HS Siphon Build issue (development)

Open atereshkov opened this issue 6 years ago • 16 comments

Hey guys, hey @chrisreyn

So I was able to test the script and I've noticed that the main functionality is working and it's good, thanks a lot @chrisreyn.

But, I found a problem with the skills leveling. Even if you set up var #justUnlockSkills 1 the script always try to level up the other skills (Midas, Sword, SC..) so I guess there is some problem.

And it can stuck for a ~minute with this toast message like rgb, colors, etc: https://imgur.com/a/RoBr7

atereshkov avatar Apr 08 '18 14:04 atereshkov

Bot does not close the offer of fairies

BblCTPEJl avatar Apr 08 '18 15:04 BblCTPEJl

@BblCTPEJl it works as for me

atereshkov avatar Apr 08 '18 15:04 atereshkov

At me it accepts and advertising begins, what to me to do?

BblCTPEJl avatar Apr 08 '18 15:04 BblCTPEJl

@BblCTPEJl Use:

var #enableFairies 0
var #enablePremiumCollect 0
var #agree 0
var #decline 1

atereshkov avatar Apr 08 '18 15:04 atereshkov

Thenks

BblCTPEJl avatar Apr 08 '18 15:04 BblCTPEJl

Also, ive seen the bot spend diamonds to hit the clanquest boss again, even if it is turned off.

Hassliebe avatar Apr 08 '18 20:04 Hassliebe

feel free to remove the toast message commands. i didnt remove them for debugging purposes but you can do that yourself. it gets "stuck" on them because it needs to toast all the messages haha

as for justUnlockSkills == 1, make sure to switch these 2 (for some reason order matters because whatever is the latter doesn't work)

elseif #justUnlockSkills == 1
		if #skillCheckStepper < 6
			if #unlocked < 4
				#unlocked = #unlocked + 1
				touchPress 0 459 755
				sleep #btnDelay
				#time = #time + #btnDelay
				goto :endLvlSkill
			elseif #unlocked >= 4
				if #minutes < #maxSkillsAtXMinutes
					goto :endLvlSkill
				else
					if #unlocked < 8
						touchPress 0 459 755
						sleep #btnDelay
						#time = #time + #btnDelay
					endif
					goto :maxSkill
				endif
			endif
		endif

***make sure you only move 2 endif, dont remove/move the 3rd one EDIT: Maybe not 2 since I copied 3 into that copy paste haha. Just make sure all if have a matching endif

elseif #justUnlockSkills == 0
		goto :maxSkill

^^^switch the places of those 2!!!

and i guess remove this part (UNLESS you want to max your skills later on towards the end of your run, this is found within the 1st spoiler-ed code above)

elseif #unlocked >= 4
				if #minutes < #maxSkillsAtXMinutes
					goto :endLvlSkill
				else
					if #unlocked < 8
						touchPress 0 459 755
						sleep #btnDelay
						#time = #time + #btnDelay
					endif
					goto :maxSkill
				endif
			endif

chrisreyn avatar Apr 08 '18 21:04 chrisreyn

@Hassliebe I never encountered that problem. If I can't reproduce it, it's gonna be hard to find a way to fix it

Before I worked on this script, it said in elite pvp that sometimes Hiro makes its own problems. It's user based and no one else experiences the problem you are experiencing. I've never touched the clan quest code ever since except for removing the time addition and yesterday, the color check for it to exit loop. Nothing else I changed

chrisreyn avatar Apr 08 '18 21:04 chrisreyn

@chrisreyn thank you, i'll look into it today

atereshkov avatar Apr 09 '18 07:04 atereshkov

Hello,

I use the update 4 version of the script and I have a problem, when I'm not strong enough to defeat a boss, we are stuck by the game until we are strong enough or that we have improved the heroes. The script at times checks to see if we are stuck or not. At this point it detects that I am blocked and so he clicks on the button to start the boss, but that incomprehensible thing, he continues to click in a loop. So I'm seeing the boss scrolling with another mob without being able to type. I have a toast at this time that says "FightBoss1".

Vhivi avatar Apr 09 '18 15:04 Vhivi

@chrisreyn the issue with the toast msg and stucking seems to have gone, but IDK how to solve the problem with justUnlockSkills. Am I doing smth wrong?

I reworked it to:

       #time = #time + 100
	getRGB #colorRed #colorGreen #colorBlue 459 755
	if #colorBlue <= -45
		sleep 10
		#time = #time + 10
		goto :endLvlSkill
	elseif #justUnlockSkills == 1
		if #skillCheckStepper < 6
			if #unlocked < 4
				#unlocked = #unlocked + 1
				touchPress 0 459 755
				sleep #btnDelay
				#time = #time + #btnDelay
				goto :endLvlSkill
			elseif #unlocked >= 4
				//if #minutes < #maxSkillsAtXMinutes
				//	goto :endLvlSkill
				//else
				//	if #unlocked < 8
				//		touchPress 0 459 755
				//		sleep #btnDelay
				//		#time = #time + #btnDelay
				//	endif
				//	goto :maxSkill
				//endif
				goto :endLvlSkill // custom
			endif
		endif
	elseif #justUnlockSkills == 0
		goto :maxSkill
	endif

atereshkov avatar Apr 09 '18 20:04 atereshkov

Agreed, only but I have consistently seen is the skills upgrade. I looked at the script as but last night and haven't figured you where the issue is, it looks ok at first glance.

rockfreak101 avatar Apr 09 '18 20:04 rockfreak101

@atereshkov yes, that should just level each skill once and prevent it from maxing later on at #maxSkillsAtXMinutes when using #justUnlockSkills 1. It's clicking nearby skills aside from what it's supposed to? I thought that was just the problem for :maxSkills section hmmm

@Vhivi i mentioned in a different issue, all you need to do is remove the goto :PressSkills line in the :pressSkills section, the IF condition with the toast FightBoss1. tell me if it is able to successfully click the fight boss button without it needing to loop

chrisreyn avatar Apr 09 '18 23:04 chrisreyn

@chrisreyn looks like something wrong elsewhere, could you pls look into this problem (because many of my mates is asking me about this problem and I had mentioned that I'll ask you to resolve this annoying bug). Also I've noticed that after this fix with switching the script is skipping only HoM and SC.

Thanks a lot.

Just my final script (if needed).

atereshkov avatar Apr 10 '18 06:04 atereshkov

@chrisreyn It's good, I confirm that the deletion solves the problem of loop.

Vhivi avatar Apr 10 '18 13:04 Vhivi

@Vhivi I guess i'll push that change in the next commit. I just wanted it to make sure it was out of the non-boss fight using the loop, but i guess it was doing more harm than good to a lot of users

@atereshkov like what i mentioned in my comment here https://github.com/Tune389/Tap-Titans-2-Progress-Bot/issues/77#issuecomment-380131948 , since you're using #justUnlockSkills 1 , probably the line touchPress 0 459 755 in :lvlSkill isn't registering. best to find your own successful clicks. play around with touchUp/touchDown/touchPress and sleep in between each. if you got yours to work, comment here, i will try it out and most probably include it in the next change if it works

chrisreyn avatar Apr 10 '18 15:04 chrisreyn