s3cmd icon indicating copy to clipboard operation
s3cmd copied to clipboard

Add notification commands

Open hrchu opened this issue 3 years ago • 1 comments

image

Sepc for ref: https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutBucketNotificationConfiguration.html#API_PutBucketNotificationConfiguration_RequestSyntax https://docs.aws.amazon.com/AmazonS3/latest/userguide/NotificationHowTo.html

hrchu avatar Mar 16 '22 03:03 hrchu

@fviard anything I can help with this?

hrchu avatar Mar 31 '22 08:03 hrchu

@fviard anything I can help with this?

hrchu avatar Aug 18 '22 12:08 hrchu

@hrchu Thank you for your PR, it is a very nice addition to s3cmd.
I'm very sorry for the long delay I took to review your PR.

I did two very minor suggestions of changes, would it be possible for you to have a look at that?
I promise to merge right away after that :-)

fviard avatar Aug 22 '22 00:08 fviard

@fviard thank you for your review and suggestions. The PR has been updated plz have a look.

I am grateful for what you've done on this project. I just wanted to make sure I've done my responsibility as a contributor so you can review this PR with less effort.

hrchu avatar Aug 22 '22 03:08 hrchu

Merged, thank you!

fviard avatar Aug 22 '22 11:08 fviard