vm370 icon indicating copy to clipboard operation
vm370 copied to clipboard

EE changes the file mode number

Open BobBolch opened this issue 3 years ago • 5 comments

If I edit an existing file. E.g.

EE TEST FILE A Or EE TEST FILE

The filemode is set to “A1” even if the existing file is “A2”.

BobBolch avatar Feb 04 '22 14:02 BobBolch

Verified the problem exists. Is the source code for EE on VM/370 CE?

EE TEST FILE A2 

File: TEST     FILE     A2  RECFM: V LRECL:  73(73) Lines:     1 Current:   TOP

      ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...
===== * * * Top of file * * *
===== /* This is a test file. */                                                
      * * * Bottom of file * * *

===> ffile
02=RingNext 03=Quit 06=SpltJ 07=PgUp 08=PgDw 10=PI 11=ClrCmd 12=Recall
Modified                                                  EE V1.2.5,  1 File(s)

I get this message.

Written new file: TEST FILE A2
Ready; T=0.07/0.10 17:36:34
l test file * ( date
Filename Filetype Fm  Format    Recs Blocks     Date    Time
TEST     FILE     A2  V    26      1      1  02/06/22   17:36
Ready; T=0.01/0.01 17:37:34

Then when I edit the file without specifying filemode, nor filemode number.

ee test file 

File: TEST     FILE     A1  RECFM: V LRECL:  73(73) Lines:     1 Current:   TOP

      ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...
===== * * * Top of file * * *
===== /* This is a test file. */                                                
      * * * Bottom of file * * *

Editing and modifying and saving does alter the filemode number.


File: TEST     FILE     A1  RECFM: V LRECL:  73(73) Lines:     2 Current:   TOP

      ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...
===== * * * Top of file * * *
===== /* This is a test file. */                                               
===== /* Added a line to the file. */                                           
      * * * Bottom of file * * *


===> ffile
02=RingNext 03=Quit 06=SpltJ 07=PgUp 08=PgDw 10=PI 11=ClrCmd 12=Recall
Modified                                                  EE V1.2.5,  1 File(s)
File written: TEST FILE A1
Ready; T=0.08/0.17 17:43:33
l test file * ( date
Filename Filetype Fm  Format    Recs Blocks     Date    Time
TEST     FILE     A1  V    31      2      1  02/06/22   17:43
Ready; T=0.01/0.01 17:43:38

marXtevens avatar Feb 06 '22 23:02 marXtevens

As a first step towards fixing the various MECAFF problems, I am working on building it from source on VM370CE. The code used internal interfaces to the C Runtime code for CMS. Some of those interfaces have been modified since the MECAFF code was distributed. I can compile and link the code now, and I am tracking down runtime bugs. Bob Bolch

On Sun, Feb 6, 2022, 6:45 PM marXtevens @.***> wrote:

Verified the problem exists.

EE TEST FILE A2

File: TEST FILE A2 RECFM: V LRECL: 73(73) Lines: 1 Current: TOP

  ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...

===== * * * Top of file * * * ===== /* This is a test file. */ * * * Bottom of file * * *

===> ffile 02=RingNext 03=Quit 06=SpltJ 07=PgUp 08=PgDw 10=PI 11=ClrCmd 12=Recall Modified EE V1.2.5, 1 File(s)

I get this message.

Written new file: TEST FILE A2 Ready; T=0.07/0.10 17:36:34 l test file * ( date Filename Filetype Fm Format Recs Blocks Date Time TEST FILE A2 V 26 1 1 02/06/22 17:36 Ready; T=0.01/0.01 17:37:34

Then when I edit the file without specifying filemode, nor filemode number.

ee test file

File: TEST FILE A1 RECFM: V LRECL: 73(73) Lines: 1 Current: TOP

  ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...

===== * * * Top of file * * * ===== /* This is a test file. */ * * * Bottom of file * * *

Editing and modifying and saving does alter the filemode number.

File: TEST FILE A1 RECFM: V LRECL: 73(73) Lines: 2 Current: TOP

  ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...

===== * * * Top of file * * * ===== /* This is a test file. / ===== / Added a line to the file. */ * * * Bottom of file * * *

===> ffile 02=RingNext 03=Quit 06=SpltJ 07=PgUp 08=PgDw 10=PI 11=ClrCmd 12=Recall Modified EE V1.2.5, 1 File(s) File written: TEST FILE A1 Ready; T=0.08/0.17 17:43:33 l test file * ( date Filename Filetype Fm Format Recs Blocks Date Time TEST FILE A1 V 31 2 1 02/06/22 17:43 Ready; T=0.01/0.01 17:43:38

— Reply to this email directly, view it on GitHub https://github.com/s390guy/vm370/issues/72#issuecomment-1030942652, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUFCBIAY5BS3Z3Q6JDKBMDUZ4BZ7ANCNFSM5NR6WT4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

BobBolch avatar Feb 07 '22 00:02 BobBolch

I am massively reworking EE to bring more XEDIT features in. Actually i am researching how EE could integrate with bREXX.

I have a small fix for this problem here if you like to test it.

diff  eecore.c.e   eecore.c.a                                                       
900a901                                                                             
>   fm[1] = fInfo->filemode[1];  /* preserve file mode number of existing file */    

EE - preserve existing file mode number - 2022-10-15-1135b EE - preserve existing file mode number - 2022-10-15-1135a EE - preserve existing file mode number - 2022-10-15-1135c EE - preserve existing file mode number - 2022-10-15-1135d EE - preserve existing file mode number - 2022-10-15-1135e EE - preserve existing file mode number - 2022-10-15-1135f

SanLorenzo59 avatar Oct 15 '22 13:10 SanLorenzo59

This fix is working for me.

BobBolch avatar Oct 16 '22 12:10 BobBolch

Binaries available: https://github.com/SanLorenzo59/mecaff/releases/tag/v1.2.5a72

diff eecore.c.f eecore.c.a                                                       
30a31                                                                            
> #include <cmssys.h>                                                            
900a902                                                                          
>   fm[1] = fInfo->filemode[1];  /* preserve file mode number of existing file */ 
Ready(00001); T=0.19/0.24 05:19:51

diff eemain.h.f eemain.h.a  
24c24                                                                               
< #define VERSION "V1.2.5"                                                          
---                                                                                 
> #define VERSION "V1.2.5a72" /* https://github.com/s390guy/vm370/issues/72 fixed */   
Ready(00001); T=0.03/0.04 05:21:53                                                        

vmarc list EE125A72 VMARC A                                             
EEMAIN   H        A1. Bytes in=    4400, bytes out=       0 (     0%).  
EECORE   C        A1. Bytes in=   24160, bytes out=       0 (     0%).  
EECORE   TEXT     A1. Bytes in=   22800, bytes out=       0 (     0%).  
EEMAIN   TEXT     A1. Bytes in=   13440, bytes out=       0 (     0%).  
EE$D     MAP      A5. Bytes in=    5920, bytes out=       0 (     0%).  
EE$D     MODULE   A1. Bytes in=  162480, bytes out=       0 (     0%).  
EE$S     MAP      A5. Bytes in=    5920, bytes out=       0 (     0%).  
EE$S     MODULE   A1. Bytes in=  162400, bytes out=       0 (     0%).  
EE$VMARC EXEC     A1. Bytes in=     400, bytes out=       0 (     0%).  

SanLorenzo59 avatar Oct 19 '22 05:10 SanLorenzo59